Eslint v9 #8236
Merged
Eslint v9 #8236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
requested changes
Jun 2, 2024
| @@ -1,4 +1,7 @@ | |||
| /** @format */ | |||
| /* eslint-disable vue/component-definition-name-casing */ | |||
| /* eslint-disable vue/require-prop-types, vue/one-component-per-file */ | |||
There was a problem hiding this comment.
require-prop-types is globally disabled, no?
There was a problem hiding this comment.
What do you mean by that? Why does this file want to report a vue error in the first place? It's not a Vue file? (Can't we disable Vue checks for non-Vue files?)
There was a problem hiding this comment.
require-prop-types is only globally disabled in the vue section, not in the js one. lsmb_elements.js is a vue component
ehuelsmann
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade ESLint to version 9.
Upgrade related plugins for JS, Vue, CSS, Markdown & Jess
Remove deprecated plugins for Dojo
Move ESLint config out of package.json to its own file, as required.