Skip to content

fix(body-reader): do not call sock:receive for reading 0 bytes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(body-reader): do not call sock:receive for reading 0 bytes #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8311216
fix(body-reader): do not call sock:receive for reading 0 bytes
Tieske Mar 18, 2024
02ccc04
fix: yield doesn't return, so needs an `else`
Tieske May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/resty/http.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,11 @@ local function _body_reader(sock, content_length, default_chunk_size)

elseif not max_chunk_size then
-- We have a length and potentially keep-alive, but want everything.
co_yield(sock:receive(content_length))
if content_length == 0 then
co_yield("")
else
co_yield(sock:receive(content_length))
end

else
-- We have a length and potentially a keep-alive, and wish to stream
Expand Down