Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signed/unsigned comparison warnings #19

Closed
wants to merge 1 commit into from
Closed

Fix signed/unsigned comparison warnings #19

wants to merge 1 commit into from

Conversation

DanRStevens
Copy link

Tagging #11

Fixes the following GCC warnings:

micropather.cpp: In member function ‘void micropather::PathCache::AddItem(const micropather::PathCache::Item&)’:
micropather.cpp:808:14: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
   if ( index == allocated )
        ~~~~~~^~~~~~~~~~~~
micropather.cpp: In member function ‘const micropather::PathCache::Item* micropather::PathCache::Find(void*, void*)’:
micropather.cpp:827:14: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
   if ( index == allocated )
        ~~~~~~^~~~~~~~~~~~

int allocated;
int nItems;
unsigned allocated;
unsigned nItems;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is probably the wrong solution. A size_t value would be much better here, though may require a few more changes.

I don't see much activity on this project, so not sure if there is any interest in fixing this. If so, I'd be happy to rework and submit a more proper fix.

@DanRStevens DanRStevens deleted the fixLinuxSignedUnsignedWarning branch September 14, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant