Skip to content

Conversation

@leeunduck
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
custom-daily-planner Ready Ready Preview Comment Sep 22, 2025 5:16pm

@leeunduck leeunduck merged commit 686ff91 into main Sep 22, 2025
2 of 3 checks passed
@leeunduck leeunduck deleted the develop branch September 22, 2025 17:16
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +41 to +42
- run: pnpm install --frozen-lockfile
- run: pnpm run lint --if-present

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Lint job fails due to misplaced --if-present flag

The lint job calls pnpm run lint --if-present, but in pnpm the --if-present option must precede the script name (pnpm run --if-present lint). As written, pnpm executes the lint script and forwards --if-present to eslint, which rejects the unknown flag and exits with code 2. This causes every CI run to fail even when linting succeeds locally.

Useful? React with 👍 / 👎.

Comment on lines +63 to +64
- run: pnpm install --frozen-lockfile
- run: pnpm run test --if-present -- --ci

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Test job cannot skip missing script

The test step also places --if-present after the script (pnpm run test --if-present -- --ci). Because pnpm treats --if-present as an argument to the script, the command fails with Missing script: test when no test script is defined, so the workflow errors even when tests are intentionally absent. To make the step optional, the flag needs to appear before the script name or the step should handle the absence explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants