Chore/Lucide-react #10
Conversation
* CDP-30 choreโ๏ธ: Prettier + ESLint ์ค์ * CDP-31 choreโ๏ธ: Husky + lint-staged * CDP-31 fix๐: CI error resolution * CDP-32 choreโ๏ธ(commit): commitlint + Conventional Commits & ์ ๊ฒ * CDP-32 fix๐(pnpm-lock.yaml): ci prettier error resolution
* CDP-35 choreโ๏ธ(lucide): ๋ผ์ด๋ธ๋ฌ๋ฆฌ ์ค์น * CDP-36 choreโ๏ธ(lucide): icon.tsx ์์ฑ & icon ํ ์คํธ * CDP-22 choreโ๏ธ(clsx): clsx ์ค์น ๋ฐ ์ ์ฉ * CDP-37 choreโ๏ธ(lucide): props์ ์ด & ํด๋ฆฐ์ฝ๋ & ์ ๊ฒ
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
๐ก Codex Review
Here are some automated review suggestions for this pull request.
โน๏ธ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting
| import type { IconProps } from "@/types/icon"; | ||
| import clsx from "clsx"; | ||
| import { icons } from "./Icon.registry"; | ||
|
|
||
| export function Icon({ name, size = 24, strokeWidth = 2, label, className, ...rest }: IconProps) { |
There was a problem hiding this comment.
[P1] Mark Icon wrapper as a client component
The shared Icon component is meant to be a reusable wrapper around lucide icons, but the file does not start with 'use client'. Next.js therefore treats this module as a server component, and any interactive component that tries to import it will fail to compile with โYouโre importing a component that needs to be rendered on the serverโฆโ. Since icons are commonly needed inside client components (buttons, inputs, etc.), this component should be marked as a client component so it can be imported safely from both server and client modules.
Useful? React with ๐ย / ๐.
๐ Pull Request
๐ PR ์ ํ
๐ ๋ณ๊ฒฝ ์ฌํญ
๐ธ ์คํฌ๋ฆฐ์ท
๐ง ๊ด๋ จ ์ด์
๐ ๏ธ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๋ฆฌ์คํธ
โ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๊ฒฐ๊ณผ
ํ์ด์ง์ ์์ด์ฝ๋ค์ด ์ ๋์ค๊ณ ์๊น, ์ ๋๊ป ๋ฑ prop์ผ๋ก ์กฐ์ ๊ฐ๋ฅํ ํ ์คํธ๋ฅผ ๋ชจ๋ ํต๊ณผํ์