Chore/shadcn UI #11
Chore/shadcn UI #11
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
๐ก Codex Review
Here are some automated review suggestions for this pull request.
โน๏ธ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting
| function Input({ className, type, ...props }: React.ComponentProps<"input">) { | ||
| return ( | ||
| <input | ||
| type={type} | ||
| data-slot="input" | ||
| className={cn( |
There was a problem hiding this comment.
[P1] Forward refs for Input component
Input is declared as a plain function component, so React cannot attach a ref to the underlying <input> element. Consumers that try to focus the input or register it with libraries like React Hook Form will hit the runtime warning โFunction components cannot be given refsโ and the ref will be null. Wrap the component in React.forwardRef and pass the ref down to the <input> to make it usable in form logic.
Useful? React with ๐ย / ๐.
๐ Pull Request
๐ PR ์ ํ
๐ ๋ณ๊ฒฝ ์ฌํญ
shadcn/ui๋ฅผ ์ค์นํ๊ณ ์ปดํฌ๋ํธ๋ฅผ ์ถ๊ฐํด๋ณด์์
๊ทธ๋ฆฌ๊ณ ๋ก์ปฌ ์๋ฒ์์ ํ ์คํธ๊น์ง ๋ง์ณค์
๐ธ ์คํฌ๋ฆฐ์ท
๐ง ๊ด๋ จ ์ด์
๐ ๏ธ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๋ฆฌ์คํธ
โ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๊ฒฐ๊ณผ