Feature/CDP-159-SelectModuleCard #41
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** specialFeature μ μ© */ | ||
| export type SpecialFeatureCardProps = BaseCardProps & { | ||
| preset: "specialFeature"; | ||
| size?: CardSize; | ||
| }; | ||
| export interface SpecialFeatureCardProps extends Omit<HTMLAttributes<HTMLDivElement>, "title"> { | ||
| icon?: React.ReactNode; | ||
| title?: React.ReactNode; | ||
| description?: React.ReactNode; | ||
| children?: React.ReactNode; | ||
| } | ||
|
|
||
| /** selectModule μ μ© */ | ||
| import * as React from "react"; | ||
|
|
There was a problem hiding this comment.
The new React import is placed after exported interfaces. TypeScript requires all import declarations to appear before any other statements, so the compiler will stop with a syntax error when it encounters import * as React from "react" in the middle of the file. Move this import to the top alongside the existing HTMLAttributes import so the module can compile.
Useful? React with πΒ / π.
π Pull Request
π PR μ ν
π λ³κ²½ μ¬ν
card μ»΄ν¬λνΈ & preset μμ & Special Feature Card μ»΄ν¬λνΈ λ¦¬ν©ν λ§
Select Module Card μ»΄ν¬λνΈ μΆκ°
πΈ μ€ν¬λ¦°μ·
π§ κ΄λ ¨ μ΄μ
π οΈ μ΅μ’ λ°°ν¬ μ κ² λ¦¬μ€νΈ
β μ΅μ’ λ°°ν¬ μ κ² κ²°κ³Ό