-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/CDP-160-CTAButton #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { cva } from "class-variance-authority"; | ||
|
|
||
| export const ctaButtonVariants = cva( | ||
| // ๊ณตํต ๋ฒ ์ด์ค | ||
| [ | ||
| "inline-flex items-center justify-center select-none", | ||
| "rounded-full px-14 py-4 t-16-m", | ||
| "transition-[background-color,color,box-shadow] duration-200 ease-out", | ||
| "focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-ring)]", | ||
| "will-change-[background-color,color,box-shadow]", | ||
| ].join(" "), | ||
| { | ||
| variants: { | ||
| /** ๋ ผ๋ฆฌ ์ํ: disabled(์ด๊ธฐ) | active(ํ์ฑ) */ | ||
| state: { | ||
| /** ์ด๊ธฐ ๋นํ์ฑ โ ํ์ ๋ฐฐ๊ฒฝ, ์ฐํ ํ ์คํธ */ | ||
| disabled: [ | ||
| "bg-[var(--color-gray-400)]", | ||
| "text-[var(--color-gray-600)]", | ||
| "cursor-not-allowed", | ||
| "shadow-none", | ||
| ].join(" "), | ||
| /** ํ์ฑ โ ํฐ ๋ฐฐ๊ฒฝ/์ง์ ํ ์คํธ + hover ์ ๋คํฌ/ํ์ดํธ ๋ฐ์ , hover ๊ทธ๋ฆผ์ */ | ||
| active: [ | ||
| "bg-white text-[var(--color-gray-900)]", | ||
| "border border-[var(--color-gray-200)]", | ||
| "shadow-[var(--shadow-soft)]", | ||
| "hover:bg-[var(--color-gray-900)] hover:text-white", | ||
| "hover:shadow-[var(--shadow-hover)]", | ||
| ].join(" "), | ||
| }, | ||
| }, | ||
| defaultVariants: { | ||
| state: "disabled", | ||
| }, | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new CTA branch
disabledis used only to select the style and then stripped from the native props viaomitKeys. Because the rendered<button>never receives itsdisabledattribute, a CTA marked as disabled is still focusable and itsonClickexecutes (e.g. the marketing pageโs์ ํ ์๋ฃbutton shows an alert even whendisabled={!isReady}). This breaks accessibility expectations and allows actions to run while the UI appears disabled. The prop should be forwarded to the native button or the handler suppressed whendisabledis true.Useful? React with ๐ย / ๐.