Feature/CDP-163-LandingWrapper #44
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ( | ||
| <html lang="ko"> | ||
| <body> | ||
| <LandingWrapper> | ||
| <main className="flex-1">{children}</main> | ||
| </LandingWrapper> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
This layout now returns <html> and <body> tags even though src/app/layout.tsx already provides the document shell. In Next.js app router only the root layout is allowed to render these elements; nested layouts should return fragments or semantic containers. Rendering another <html> inside the provider tree produces invalid markup and can trigger hydration warnings or build errors when navigating to marketing pages. Wrapping the children with LandingWrapper should happen inside a fragment instead.
Useful? React with πΒ / π.
π Pull Request
π PR μ ν
π λ³κ²½ μ¬ν
λλ©νμ΄μ§μ λ μ΄μμμΈ Landing Wrapper μΆκ°
πΈ μ€ν¬λ¦°μ·
π§ κ΄λ ¨ μ΄μ
π οΈ μ΅μ’ λ°°ν¬ μ κ² λ¦¬μ€νΈ
β μ΅μ’ λ°°ν¬ μ κ² κ²°κ³Ό