-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/CDP-162-LandingLayout #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ก Codex Review
Here are some automated review suggestions for this pull request.
โน๏ธ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Link href="/" aria-label="MyPlanMate ํ์ผ๋ก ์ด๋"> | ||
| <Image | ||
| src="/images/logo.png" | ||
| alt="MyPlanMate ๋ก๊ณ " | ||
| width={150} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix logo path casing in navbar
The new logo asset was added as public/images/Logo.png (capital L) but the navbar still references src="/images/logo.png". On case-sensitive deployments (Linux builds and Vercel), this mismatch will return a 404 so the brand logo will not render in the header. Update the reference to match the fileโs casing or rename the asset to keep the path consistent.
Useful? React with ๐ย / ๐.
| <Link href="/" aria-label="MyPlanMate ํ์ผ๋ก ์ด๋" className="flex items-center gap-2"> | ||
| <Image | ||
| src="/images/logo.png" | ||
| alt="MyPlanMate ๋ก๊ณ " | ||
| width={150} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix logo path casing in footer
The footer renders the same logo using src="/images/logo.png", but the only image committed is public/images/Logo.png. Because Next.js serves files case-sensitively in production, the footerโs logo will fail to load and display as a broken image. Align the string casing or rename the asset so the served file matches the requested path.
Useful? React with ๐ย / ๐.
๐ Pull Request
๐ PR ์ ํ
๐ ๋ณ๊ฒฝ ์ฌํญ
header์ footer ์ปดํฌ๋ํธ๋ฅผ ์์ฑํ๊ณ layout์ ๋ฃ์์
๐ธ ์คํฌ๋ฆฐ์ท
๐ง ๊ด๋ จ ์ด์
๐ ๏ธ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๋ฆฌ์คํธ
โ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๊ฒฐ๊ณผ