Feature/CDP-168-LandingHero #49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Link href="/login"> | ||
| <Button preset="hero" pill> | ||
| <span className="inline-flex items-center gap-4"> | ||
| <Icon name="monitor" /> | ||
| <span>Desktop</span> | ||
| </span> | ||
| </Button> | ||
| </Link> |
There was a problem hiding this comment.
Each CTA wraps the shared Button component in next/link. Because Button renders a <button> element, the output becomes <a><button>β¦</button></a>, which is invalid HTML and can block keyboard interaction in some browsers and screen readers. Consider rendering the link as the button (<Button asChild><Link β¦ /></Button>) or styling the Link directly so only a single interactive element is produced.
Useful? React with πΒ / π.
| <video | ||
| className="h-full w-full object-cover" | ||
| src="/videos/landing-hero.mp4" | ||
| autoPlay |
There was a problem hiding this comment.
The hero animation component references /videos/landing-hero.mp4, but no file with that path exists under public/ in this repository. At runtime the <video> tag will 404 and render empty, so users never see the intended animation. Either add the video asset to public/videos/landing-hero.mp4 or adjust the source to an existing file.
Useful? React with πΒ / π.
π Pull Request
π PR μ ν
π λ³κ²½ μ¬ν
Hero Section & Title & CTA & Animaition μ»΄ν¬λνΈλ₯Ό μΆκ°ν΄ νμ΄λ‘ μΉμ μ μλ£νμ
λͺ¨λ°μΌ μμ λ μλ£
cnμ΄ μλ€μ΄κ° μ»΄ν¬λνΈμ cnμ λ£λ 리ν©ν λ§μ νμ
MainSection CSS μμ μμ μ΄ μμμ
πΈ μ€ν¬λ¦°μ·
π§ κ΄λ ¨ μ΄μ
π οΈ μ΅μ’ λ°°ν¬ μ κ² λ¦¬μ€νΈ
β μ΅μ’ λ°°ν¬ μ κ² κ²°κ³Ό