Feature/CDP-185-LandingAnimation #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { UseInViewOptions, UseInViewResult } from "@/types/inView"; | ||
| import { useEffect, useRef, useState } from "react"; | ||
|
|
||
| export function useInView(options: UseInViewOptions = {}): UseInViewResult { | ||
| const { threshold = 0.2, rootMargin = "0px", once = true } = options; | ||
|
|
||
| const ref = useRef<HTMLDivElement | null>(null); | ||
| const [isInView, setIsInView] = useState(false); |
There was a problem hiding this comment.
The hook currently creates ref with useRef<HTMLDivElement | null> and exposes that type. In this commit the hook is attached to <section> elements in LandingFeaturesSection1 and LandingFeaturesSection2, but under the repoβs strict TypeScript configuration a RefObject<HTMLDivElement> cannot be assigned to a section (RefObject<HTMLElement> is required). As a result the new components fail to compile. Consider widening the element type to HTMLElement or making the hook generic so it can be used with nonβdiv root elements.
Useful? React with πΒ / π.
π Pull Request
π PR μ ν
π λ³κ²½ μ¬ν
Fade-in & Bounce μ λλ©μ΄μ μΆκ°
Full page μ λλ©μ΄μ μΆκ°
πΈ μ€ν¬λ¦°μ·
π§ κ΄λ ¨ μ΄μ
π οΈ μ΅μ’ λ°°ν¬ μ κ² λ¦¬μ€νΈ
β μ΅μ’ λ°°ν¬ μ κ² κ²°κ³Ό