Chore/CodeStyle-CommitConvention #8
Conversation
* CDP-30 choreโ๏ธ: Prettier + ESLint ์ค์ * CDP-31 choreโ๏ธ: Husky + lint-staged * CDP-31 fix๐: CI error resolution * CDP-32 choreโ๏ธ(commit): commitlint + Conventional Commits & ์ ๊ฒ * CDP-32 fix๐(pnpm-lock.yaml): ci prettier error resolution
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # 1) ๋ณ๊ฒฝ ํ์ผ๋ง ์๋ ์์ (eslint --fix, prettier --write) | ||
| if ! pnpm lint-staged; then | ||
| echo |
There was a problem hiding this comment.
[P1] Call lint-staged via pnpm exec to avoid hook failures
The new pre-commit hook runs pnpm lint-staged, but pnpm only executes binaries this way when a script with that name exists. There is no lint-staged script in package.json, so every commit will fail with ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "lint-staged" not found. Either add a "lint-staged": "lint-staged" script or invoke the binary with pnpm exec lint-staged so the hook can run.
Useful? React with ๐ย / ๐.
| pnpm commitlint --edit "$1" || { | ||
| echo | ||
| echo "โ ์ปค๋ฐ ๋ฉ์์ง ๊ท์น ์๋ฐ!" | ||
| echo " ํ์: CDP-์ซ์ type์ด๋ชจ์ง(scope): subject" | ||
| echo " ์์: CDP-31 fix๐(ci): CI error resolution" | ||
| echo " ํ์ฉ: featโจ, fix๐, refactor๐จ, style๐จ, choreโ๏ธ, docs๐, test๐งช" |
There was a problem hiding this comment.
[P1] Use pnpm exec for commitlint in commit-msg hook
The commit message hook invokes pnpm commitlint, but pnpm cannot find that command because the repo defines no commitlint script. This means every commit will abort with โCommand "commitlint" not foundโ and the message is never checked. Run pnpm exec commitlint --edit "$1" (or add a commitlint script) to make the hook work.
Useful? React with ๐ย / ๐.
๐ Pull Request
๐ PR ์ ํ
๐ ๋ณ๊ฒฝ ์ฌํญ
๐ธ ์คํฌ๋ฆฐ์ท
๐ง ๊ด๋ จ ์ด์
๐ ๏ธ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๋ฆฌ์คํธ
โ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๊ฒฐ๊ณผ
eslint & prettier ์ ์ฉ, commitlint ์ ์ฉ ๋ฐ ์ ๊ฒ ํ์ธ