Analytics: Deactivate all support for async span_fn for now#1947
Merged
kevin-legion merged 1 commit intomainfrom Jun 1, 2022
Merged
Analytics: Deactivate all support for async span_fn for now#1947kevin-legion merged 1 commit intomainfrom
kevin-legion merged 1 commit intomainfrom
Conversation
mad-legion
approved these changes
Jun 1, 2022
kevin-legion
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the recent changes didn't work as expected.
I made an experimental branch here: #1946 that tries to bring back support to async span fn.