Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphite keymaps #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aljustiet
Copy link

@aljustiet aljustiet commented Jan 5, 2025

This keyboard layout

@legionus
Copy link
Owner

legionus commented Jan 7, 2025

@aljustiet Thanks for the PR. I don't mind adding graphite layout, but I don't think the naming of the layouts is successful. You have duplication in the naming. I propose such naming: data/keymaps/i386/graphite/<language>-<variant>.map. This approach will allow us not to invent something new in case graphite keymaps for other languages appear.

According to such a naming convention:

data/keymaps/i386/graphite/en.map
data/keymaps/i386/graphite/en-angle-kp.map

You can load them up like this:

$ loadkeys graphite/en
$ loadkeys graphite/en-angle-kp

@legionus
Copy link
Owner

legionus commented Jan 7, 2025

Also kbd uses DCO to format patches. Please add Signed-off-by tag in the commit message and use real name.

https://github.com/legionus/kbd/blob/master/docs/process/howto-contribute.md#sending-patches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants