Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend known slice with Go 1.23 compiler directives #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexandear
Copy link

@alexandear alexandear commented Nov 20, 2024

@alexandear alexandear force-pushed the extend-known-compiler-directives branch from ed6cbb1 to 07893be Compare November 20, 2024 12:00
@alexandear alexandear changed the title Extend known for Go 1.23 compiler directives Extend known slice with Go 1.23 compiler directives Nov 20, 2024
@Antonboom
Copy link

(cc) @ldez
related to https://github.com/Antonboom/nilnil/actions/runs/12358099538/job/34487829213

@leighmcculloch
Copy link
Owner

I don't think these two cases are actual directives that are supported by the compiler. They're just examples in the documentation.

Do you have examples of them actually in use or supported by the compiler?

Can you reduce the PR to only //go:binary-only-package?

@alexandear
Copy link
Author

alexandear commented Dec 16, 2024

I don't think these two cases are actual directives that are supported by the compiler. They're just examples in the documentation.

Do you have examples of them actually in use or supported by the compiler?

Can you reduce the PR to only //go:binary-only-package?

Thank you for your feedback. I'm not completely clear on which lines should be adjusted. Could you please comment directly on the PR to specify the lines to be removed? This will help me make the correct updates more efficiently. Thank you!

Anyway:

@alexandear alexandear force-pushed the extend-known-compiler-directives branch 2 times, most recently from 97659e8 to e49973a Compare December 17, 2024 18:33
@alexandear alexandear force-pushed the extend-known-compiler-directives branch from e49973a to 3e2eea9 Compare December 17, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants