✅ (BehaviorKit): Add init to cover all unexpected calls

leka · Feb 1, 2024 · 210cbca · 210cbca
1 parent cd805f1
commit 210cbca
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 2 deletions.
diff --git a/include/interface/libs/BehaviorKit.h b/include/interface/libs/BehaviorKit.h
@@ -17,6 +17,7 @@ class BehaviorKit
   public:
 	virtual ~BehaviorKit() = default;
 
+	virtual void init()														   = 0;
 	virtual void registerBehaviors(std::span<interface::Behavior *> behaviors) = 0;
 	virtual void setTimeoutDuration(std::chrono::seconds duration)			   = 0;
 	virtual void start(interface::Behavior *behavior)						   = 0;

diff --git a/libs/BehaviorKit/include/BehaviorKit.h b/libs/BehaviorKit/include/BehaviorKit.h
@@ -16,8 +16,12 @@ namespace leka {
 class BehaviorKit : public interface::BehaviorKit
 {
   public:
-	explicit BehaviorKit(interface::Timeout &timeout);
+	explicit BehaviorKit(interface::Timeout &timeout) : _timeout(timeout)
+	{
+		// nothing to do
+	}
 
+	void init() final;
 	void registerBehaviors(std::span<interface::Behavior *> behaviors) final;
 	void setTimeoutDuration(std::chrono::seconds duration) final;
 

diff --git a/libs/BehaviorKit/source/BehaviorKit.cpp b/libs/BehaviorKit/source/BehaviorKit.cpp
@@ -7,7 +7,7 @@
 
 using namespace leka;
 
-BehaviorKit::BehaviorKit(interface::Timeout &timeout) : _timeout(timeout)
+void BehaviorKit::init()
 {
 	_timeout.onTimeout([this] { stop(); });
 }

diff --git a/libs/BehaviorKit/tests/BehaviorKit_test.cpp b/libs/BehaviorKit/tests/BehaviorKit_test.cpp
@@ -10,6 +10,7 @@
 #include "mocks/leka/Timeout.h"
 
 using namespace leka;
+using namespace std::chrono_literals;
 
 using ::testing::Return;
 
@@ -33,8 +34,18 @@ TEST_F(BehaviorKitTest, initialization)
 	ASSERT_NE(&behaviorkit, nullptr);
 }
 
+TEST_F(BehaviorKitTest, initialize)
+{
+	EXPECT_CALL(mock_timeout, onTimeout);
+
+	behaviorkit.init();
+}
+
 TEST_F(BehaviorKitTest, startFirstBehavior)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({&mock_behavior_a});
 	behaviorkit.registerBehaviors(behaviors);
 
@@ -47,6 +58,9 @@ TEST_F(BehaviorKitTest, startFirstBehavior)
 
 TEST_F(BehaviorKitTest, startBehaviorNullPtr)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	EXPECT_CALL(mock_timeout, stop);
 	EXPECT_CALL(mock_timeout, start).Times(0);
 
@@ -55,6 +69,9 @@ TEST_F(BehaviorKitTest, startBehaviorNullPtr)
 
 TEST_F(BehaviorKitTest, startFirstBehaviorID)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -75,6 +92,9 @@ TEST_F(BehaviorKitTest, startFirstBehaviorID)
 
 TEST_F(BehaviorKitTest, startBehaviorIDNotRegistered)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -94,6 +114,9 @@ TEST_F(BehaviorKitTest, startBehaviorIDNotRegistered)
 
 TEST_F(BehaviorKitTest, startBehaviorNotRegistered)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 	});
@@ -108,6 +131,9 @@ TEST_F(BehaviorKitTest, startBehaviorNotRegistered)
 
 TEST_F(BehaviorKitTest, startAnyBehavior)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -130,6 +156,9 @@ TEST_F(BehaviorKitTest, startAnyBehavior)
 
 TEST_F(BehaviorKitTest, setTimeoutDuration)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({&mock_behavior_a});
 	behaviorkit.registerBehaviors(behaviors);