✅ (BehaviorKit): Add init to cover all unexpected calls

leka · Dec 19, 2023 · edd60e0 · edd60e0
1 parent 9a29261
commit edd60e0
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 3 deletions.
diff --git a/include/interface/libs/BehaviorKit.h b/include/interface/libs/BehaviorKit.h
@@ -17,6 +17,7 @@ class BehaviorKit
   public:
 	virtual ~BehaviorKit() = default;
 
+	virtual void init()														   = 0;
 	virtual void registerBehaviors(std::span<interface::Behavior *> behaviors) = 0;
 	virtual void setTimeoutDuration(std::chrono::seconds duration)			   = 0;
 	virtual void start(interface::Behavior *behavior)						   = 0;

diff --git a/libs/BehaviorKit/include/BehaviorKit.h b/libs/BehaviorKit/include/BehaviorKit.h
@@ -17,8 +17,13 @@ namespace leka {
 class BehaviorKit : public interface::BehaviorKit
 {
   public:
-	explicit BehaviorKit(interface::EventLoop &event_loop, interface::Timeout &timeout);
+	explicit BehaviorKit(interface::EventLoop &event_loop, interface::Timeout &timeout)
+		: _event_loop(event_loop), _timeout(timeout)
+	{
+		// nothing to do
+	}
 
+	void init() final;
 	void registerBehaviors(std::span<interface::Behavior *> behaviors) final;
 	void setTimeoutDuration(std::chrono::seconds duration) final;
 

diff --git a/libs/BehaviorKit/source/BehaviorKit.cpp b/libs/BehaviorKit/source/BehaviorKit.cpp
@@ -7,8 +7,7 @@
 
 using namespace leka;
 
-BehaviorKit::BehaviorKit(interface::EventLoop &event_loop, interface::Timeout &timeout)
-	: _event_loop(event_loop), _timeout(timeout)
+void BehaviorKit::init()
 {
 	_event_loop.registerCallback([this] { run(); });
 	_timeout.onTimeout([this] { stop(); });

diff --git a/libs/BehaviorKit/tests/BehaviorKit_test.cpp b/libs/BehaviorKit/tests/BehaviorKit_test.cpp
@@ -11,6 +11,7 @@
 #include "stubs/leka/EventLoopKit.h"
 
 using namespace leka;
+using namespace std::chrono_literals;
 
 using ::testing::Return;
 
@@ -35,8 +36,18 @@ TEST_F(BehaviorKitTest, initialization)
 	ASSERT_NE(&behaviorkit, nullptr);
 }
 
+TEST_F(BehaviorKitTest, initialize)
+{
+	EXPECT_CALL(mock_timeout, onTimeout);
+
+	behaviorkit.init();
+}
+
 TEST_F(BehaviorKitTest, startFirstBehavior)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({&mock_behavior_a});
 	behaviorkit.registerBehaviors(behaviors);
 
@@ -49,6 +60,9 @@ TEST_F(BehaviorKitTest, startFirstBehavior)
 
 TEST_F(BehaviorKitTest, startBehaviorNullPtr)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	EXPECT_CALL(mock_timeout, stop);
 	EXPECT_CALL(mock_timeout, start).Times(0);
 
@@ -57,6 +71,9 @@ TEST_F(BehaviorKitTest, startBehaviorNullPtr)
 
 TEST_F(BehaviorKitTest, startFirstBehaviorID)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -77,6 +94,9 @@ TEST_F(BehaviorKitTest, startFirstBehaviorID)
 
 TEST_F(BehaviorKitTest, startBehaviorIDNotRegistered)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -96,6 +116,9 @@ TEST_F(BehaviorKitTest, startBehaviorIDNotRegistered)
 
 TEST_F(BehaviorKitTest, startBehaviorNotRegistered)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 	});
@@ -110,6 +133,9 @@ TEST_F(BehaviorKitTest, startBehaviorNotRegistered)
 
 TEST_F(BehaviorKitTest, startAnyBehavior)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({
 		&mock_behavior_a,
 		&mock_behavior_b,
@@ -132,6 +158,9 @@ TEST_F(BehaviorKitTest, startAnyBehavior)
 
 TEST_F(BehaviorKitTest, setTimeoutDuration)
 {
+	EXPECT_CALL(mock_timeout, onTimeout);
+	behaviorkit.init();
+
 	auto behaviors = std::to_array<interface::Behavior *>({&mock_behavior_a});
 	behaviorkit.registerBehaviors(behaviors);