Python 3 and APIv5 rewrite (Live DNS) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ipv6 was not working anymore Also updated ipv4 for consistency
When using both IPv4 and IPv6, we want the record to be updated if *at least* one IP changed (v4 or v6, not necessarily both). This commit changes the check_if_ip_changed logic accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since I've accidentally migrated my domain to APIv5, I've rewritten the script to work with Python 3 and the newer API v5 instead of API v4. Public IP is retrieved through icanhaz.
Fork is available at: https://github.com/ORelio/gandi-dyndns-v5
This pull request also includes changes from my previous PR that implements icanhaz and fixes a small bug that prevents record update in IPv4+IPv6 mode when only one IP address has changed : #17