Let us not construct a new iterator each time "end()" is called.

lemire · Mar 7, 2017 · b04a575 · b04a575
1 parent d712200
commit b04a575
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/include/concise.h b/include/concise.h
@@ -431,7 +431,7 @@ template <bool wah_mode = false> class ConciseSet {
 
   const_iterator begin() const;
 
-  const_iterator end() const;
+  const_iterator & end() const;
 
   bool contains(uint32_t o) const {
     if (isEmpty() || ((int32_t)o > last) || (o > MAX_ALLOWED_INTEGER)) {
@@ -1018,7 +1018,8 @@ ConciseSet<wah_mode>::begin() const {
 }
 
 template <bool wah_mode>
-inline ConciseSetBitForwardIterator<wah_mode>
+inline ConciseSetBitForwardIterator<wah_mode>&
 ConciseSet<wah_mode>::end() const {
-  return ConciseSetBitForwardIterator<wah_mode>(*this, true);
+  static ConciseSetBitForwardIterator<wah_mode> endp(*this, true);
+  return endp;
 }