Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev better logging #39

Merged
merged 2 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-meals-rule.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@vslint/jest": patch
---

Updates logging behavior to make it clearer whether the file's html change
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jest/src/extend-expect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const extendExpectDesignReviewer = (unsafeArgs: DesignReviewMatcher) => {
if (!model?.modelName || !model?.key) {
throw new Error(
process.env.CI
? "vslint is running in a CI environment but the design snapshot does not exist for this test. vslint should never generate snapshots in CI as this could cause unintended model usage. Make sure to run this test locally and commit the results so re-review doesn't happen in CI."
? `vslint is running in a CI environment but ${existingSnapshotFileContent ? "design snapshot contents have changed in this environment." : "no design snapshot found for this test."} vslint should never generate snapshots in CI as this could cause unintended model usage. Make sure to run this test locally and commit the results so re-review doesn't happen in CI.`
: "Component changed but can't re-run review as model name and key are not correctly set in `extendExpectDesignReviewer`. If you are setting the model key with an environment variable, make sure that `process.env.OPENAI_API_KEY` or `process.env.GEMINI_API_KEY` is set by running export OPENAI_API_KEY=...",
);
}
Expand Down