Please allow non-manufacturer launchers to use DefaultBadger for all devices #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final12345
changed the title
peswani
approved these changes
Jun 9, 2018
|
I'm not a contributor to this repo, but I don't understand this modification nonetheless. If the device is not manufactured by ZUK, OPPO, VIVO, or ZTE then it would go into the else { } block anyway and use DefaultBadger() which is the desired behavior you want right? I would think that if it was manufactured by ZUK that you would want it to use the ZukHomeBadger instead of the DefaultBadger? Correct me if I'm wrong? |
No. If device is ZUK, but current launcher is not "ZUK launcher", I want it to use the DefaultBadger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Sorry for my poor English!
Would you please change this section of code?
Otherwise launchers that not included to ShortcutBadger does not have possibility to use DefaultBadger on devices manufactured by "ZUK", "OPPO", "VIVO", "ZTE".
Thank you!