Skip to content

Fix DropDownButton not working inside ToolBar overflow #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix DropDownButton not working inside ToolBar overflow #1523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39134e3
Update DropDownButton.cs
Nuklon Aug 28, 2025
66e8a3e
Update DropDownButton.cs
Nuklon Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Wpf.Ui/Controls/DropDownButton/DropDownButton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// All Rights Reserved.

using System.Windows.Controls;
using System.Windows.Input;

// ReSharper disable once CheckNamespace
namespace Wpf.Ui.Controls;
Expand All @@ -15,6 +16,11 @@ public class DropDownButton : Button
{
private ContextMenu? _contextMenu;

public DropDownButton()
{
PreviewMouseLeftButtonUp += OnPreviewMouseLeftButtonUp;
}

/// <summary>Identifies the <see cref="Flyout"/> dependency property.</summary>
public static readonly DependencyProperty FlyoutProperty = DependencyProperty.Register(
nameof(Flyout),
Expand Down Expand Up @@ -87,21 +93,16 @@ protected virtual void OnContextMenuOpened(object sender, RoutedEventArgs e)

protected virtual void OnIsDropDownOpenChanged(bool currentValue) { }

protected override void OnClick()
private void OnPreviewMouseLeftButtonUp(object sender, MouseButtonEventArgs e)
{
base.OnClick();

if (_contextMenu is null)
{
return;
}

_contextMenu.SetCurrentValue(MinWidthProperty, ActualWidth);
_contextMenu.SetCurrentValue(ContextMenu.PlacementTargetProperty, this);
_contextMenu.SetCurrentValue(
ContextMenu.PlacementProperty,
System.Windows.Controls.Primitives.PlacementMode.Bottom
);
_contextMenu.SetCurrentValue(ContextMenu.PlacementProperty, System.Windows.Controls.Primitives.PlacementMode.Bottom);
_contextMenu.SetCurrentValue(ContextMenu.IsOpenProperty, true);
}
}