Conversation
Signed-off-by: Enzo "raskyld" Nocera <enzo@nocera.eu>
benwis
left a comment
benwis
left a comment
There was a problem hiding this comment.
Overall this looks like a good start. Unless I'm misunderstanding there'll be quite a bit more integration code added in here
| @@ -0,0 +1,60 @@ | |||
| //! A first-party support of the `wasm32-wasip1` target for the **Server-Side** | |||
There was a problem hiding this comment.
I might have misunderstood, but I thought you were going for wasip2?
There was a problem hiding this comment.
Yes, it is actually targeting the Preview 2 of WASI, but I don't see mention of the Tier upgrade in the latest Rust release notes so I am not sure wasip2 toolchain is ready. I think I should ask to Bytecode Alliance fellows
There was a problem hiding this comment.
So atm, most people target wasip1 and use an adapter
There was a problem hiding this comment.
It probably isn't, that'd be a good question though. I wonder how things would go if you ran cargo component on the server
There was a problem hiding this comment.
Honestly I haven't tried it out but I would expect it to fail since you need a pretty specific toolchain (that is bundled with the Tier 2 upgrade)
I asked about that there: https://bytecodealliance.zulipchat.com/#narrow/channel/235408-rust-toolchain/topic/Promoting.20wasm32-wasip2.20to.20tier.202/near/478774747
There was a problem hiding this comment.
Oh Alex confirmed that! 🎉
So I can try actually! So I can try it once we release the origin PR in leptos, I will merge it as is for now but follow-up cleaning-up and production readiness PRs should arrive soon!
| /// allowing you to choose between synchronous response | ||
| /// (i.e. sending the whole response) and asynchronous response | ||
| /// (i.e. streaming the response). | ||
| pub struct Response(pub http::Response<Body>); |
There was a problem hiding this comment.
Nice, I like the Response type
2 participants
This is a migration from leptos-rs/leptos#3063 so we have the integration crate off-tree.
Note that it won't compile until the referenced PR is merged upstream so we can use the new versions of
any_spawnerand other in-tree crates.