Skip to content

Use JSpecify static analysis annotations #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: SNAPSHOT
Choose a base branch
from
Open

Use JSpecify static analysis annotations #442

wants to merge 8 commits into from

Conversation

joshuajaharwood
Copy link

  • Bump spotless plugin to latest
  • Only use JSpecify annotations, remove Jetbrains and JSR-305 dependencies
  • Make all usages compliant with annotation method contracts

@lessthanoptimal
Copy link
Owner

Thanks for the PR. Could you resolve the merge conflicts. That is likely caused by the recent update to Java 25 and several libraries being updated. If this goes well I'll look into updating updating other libraries that I maintain.

Based on a conversation with GPT, it looks like we might need to set -XDaddTypeAnnotationsToSymbol=true to true because the byte code generated is for Java 11. Could you investigate that too?

@joshuajaharwood
Copy link
Author

I will get to this eventually, I'm just absolutely hammered with work right now!

@lessthanoptimal
Copy link
Owner

I can relate. No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuajaharwood @lessthanoptimal