Feature/Add DMatrixRMaj#get2DData interface #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee08b397
changed the title
lessthanoptimal
requested changes
Jul 7, 2023
|
looks like spotless needs to be run again too. See error message for details. Thanks. |
|
Can you squash your PR into a single commit? Otherwise looks good! |
|
never mind. Git let me do it. Thanks for the contribution. |
|
Thanks for the review. Will squash in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the EJML project.
This PR is for Feature Request #193.
DMatrixRMajcan be converted from a double-dimensional array (a 2D arraydoulbe[][]) in one of its constructors. But, not the other way around. This new interfaceDMatrixRMaj#get2DDatawill makeDMatrixRMajeasier to use.Before submitting this PR, please make sure:
./gradlew spotlessJavaApply