Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] RTTTL feature was not working with ESP32 IDF 5.x #5213

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Jan 4, 2025

Resolves #5212

Bugfix

  • Feature RTTTL wasn't enabled for ESP32 builds because of a missed S&R
  • Apply IDF 5.x adjustments to RTTTL feature

TODO:

  • Testing by reporter

@tonhuisman tonhuisman changed the title [Bugfix] RTTTL feature was not enabled for ESP32 Collection builds [Bugfix] RTTTL feature was not working with ESP32 IDF 5.x Jan 11, 2025
@TD-er TD-er merged commit d9dc6be into letscontrolit:mega Jan 16, 2025
168 checks passed
@tonhuisman tonhuisman deleted the bugfix/Build-RTTTL-not-included-in-esp32-collection-builds branch January 16, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new [BUG] with Christmas Edition 2024 ---> RTTTL doesn't full play
2 participants