Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound_exporter.go: Fixed startup message log output formatting #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpds
Copy link
Contributor

@jpds jpds commented May 19, 2024

Currently, the startup logs look like this:

level=info ts=2024-05-19T16:03:41.578Z caller=unbound_exporter.go:551 Startingunbound_exporter=(MISSING)

This change matches the node_exporter code, and looks like this:

level=info ts=2024-05-19T16:23:49.275Z caller=unbound_exporter.go:552 msg="Starting unbound_exporter" version="(version=, branch=, revision=d015a196b8f51a7fca8692db07590e64ecee0eed-modified)"

Version information can be embedded into the Go binary using ldflags: https://github.com/NixOS/nixpkgs/blob/23e46d7bdde6c2e048d490e1de0fb9391034cf6c/pkgs/servers/monitoring/prometheus/node-exporter.nix#L27-L35 - I do not know where to add this to this project.

@pgporada pgporada mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants