Add locale for ubuntu #493
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locale problem also happens on some Ubuntu installations. The solution currently sits in the Windows Update partial, but it makes more sense to include it in a partial that caters for both Windows and Ubuntu. The start of the CLI tools section is a good place to do this: - It fits better with the setup actions we do in that section. - It is still early enough: the problem only gets triggered after dotfiles. This commit will automatically move this in the right place. No need to change the `build.rb`. The next rebuild of the data-setup will then also include these changes. DA and DE setups do not rely on these partials. Also corrected some typos in the FR partial.
ajdubovoy
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locale problem also happens on some Ubuntu installations.
The solution currently sits in the Windows Update partial, but it makes more sense to include it in a partial that caters for both Windows and Ubuntu.
The start of the CLI tools section is a good place to do this:
This commit will automatically move this in the right place. No need to change the
build.rb. The next rebuild of the data-setup will then also include these changes. DA and DE setups do not rely on these partials.Also corrected some typos in the FR partial.