Critical fix for tinyproto queues #26

lexus2k · Feb 6, 2022 · dfeeb2d · dfeeb2d
1 parent 37bbc98
commit dfeeb2d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/proto/fd/tiny_fd.c b/src/proto/fd/tiny_fd.c
@@ -294,6 +294,11 @@ static void __confirm_sent_frames(tiny_fd_handle_t handle, uint8_t peer, uint8_t
                 tiny_mutex_lock(&handle->frames.mutex);
             }
             tiny_fd_queue_free( &handle->frames.i_queue, slot );
+            if ( tiny_fd_queue_has_free_slots( &handle->frames.i_queue ) )
+            {
+                // Unblock tx queue to allow application to put new frames for sending
+                tiny_events_set(&handle->events, FD_EVENT_QUEUE_HAS_FREE_SLOTS);
+            }
         }
         else
         {
@@ -304,11 +309,6 @@ static void __confirm_sent_frames(tiny_fd_handle_t handle, uint8_t peer, uint8_t
         handle->peers[peer].confirm_ns = (handle->peers[peer].confirm_ns + 1) & seq_bits_mask;
         handle->peers[peer].retries = handle->retries;
     }
-    if ( tiny_fd_queue_has_free_slots( &handle->frames.i_queue ) )
-    {
-        // Unblock tx queue to allow application to put new frames for sending
-        tiny_events_set(&handle->events, FD_EVENT_QUEUE_HAS_FREE_SLOTS);
-    }
     if ( __can_accept_i_frames( handle, peer ) )
     {
         // Unblock specific peer to accept new frames for sending
@@ -1076,6 +1076,7 @@ int tiny_fd_send_packet(tiny_fd_handle_t handle, const void *data, int len)
             else
             {
                 result = TINY_ERR_TIMEOUT;
+                // !!!! If this log appears, then in the code of the protocol something is definitely wrong !!!!
                 LOG(TINY_LOG_ERR, "[%p] Wrong flag FD_EVENT_QUEUE_HAS_FREE_SLOTS\n", handle);
             }
             if ( __can_accept_i_frames( handle, peer ) )