Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for go1.23 #1034

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -10,6 +10,9 @@
# Test binary, built with `go test -c`
*.test

# make build-tests artifacts
tests/**/eden.*.test*

# Output of the go coverage tool, specifically when used with LiteIDE
*.out

4 changes: 2 additions & 2 deletions tests/escript/go-internal/testscript/testing_1.18.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build go1.18
// +build go1.18
//go:build go1.18 && !go1.23
// +build go1.18,!go1.23

package testscript

81 changes: 81 additions & 0 deletions tests/escript/go-internal/testscript/testing_1.23.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
//go:build go1.23
// +build go1.23

package testscript

import (
"io"
"reflect"
"testing"
"time"
)

type nopTestDeps struct{}

// corpusEntry is an alias to the same type as internal/fuzz.CorpusEntry.
// We use a type alias because we don't want to export this type, and we can't
// import internal/fuzz from testing.
type corpusEntry = struct {
Parent string
Path string
Data []byte
Values []interface{}
Generation int
IsSeed bool
}

func (d nopTestDeps) CoordinateFuzzing(_ time.Duration, _ int64, _ time.Duration, _ int64, _ int, _ []corpusEntry, _ []reflect.Type, _ string, _ string) error {
return nil
}

func (d nopTestDeps) RunFuzzWorker(_ func(corpusEntry) error) error {
return nil
}

func (d nopTestDeps) ReadCorpus(_ string, _ []reflect.Type) ([]corpusEntry, error) {
return nil, nil
}

func (d nopTestDeps) CheckCorpus(_ []interface{}, _ []reflect.Type) error {
return nil
}

func (d nopTestDeps) ResetCoverage() {
return
}

func (d nopTestDeps) SnapshotCoverage() {
return
}

func (d nopTestDeps) InitRuntimeCoverage() (mode string, tearDown func(coverprofile string, gocoverdir string) (string, error), snapcov func() float64) {
return
}

func (nopTestDeps) SetPanicOnExit0(_ bool) {}

func (nopTestDeps) MatchString(_, _ string) (result bool, err error) {
return false, nil
}

func (nopTestDeps) StartCPUProfile(_ io.Writer) error {
return nil
}

func (nopTestDeps) StopCPUProfile() {}

func (nopTestDeps) WriteProfileTo(_ string, _ io.Writer, _ int) error {
return nil
}
func (nopTestDeps) ImportPath() string {
return ""
}
func (nopTestDeps) StartTestLog(_ io.Writer) {}

func (nopTestDeps) StopTestLog() error {
return nil
}

func getTestingMain() *testing.M {
return testing.MainStart(nopTestDeps{}, nil, nil, nil, nil)
}

Unchanged files with check annotations Beta

eden network create 10.11.12.0/24 -n n1
eden pod deploy -n eclient --memory=512MB {{template "eclient_image"}} -p {{$port}}:22 --networks=n1
test eden.app.test -test.v -timewait 20m RUNNING eclient

Check failure on line 17 in tests/eclient/testdata/metadata.txt

GitHub Actions / Execute Eden test workflow / Smoke tests (ext4, false)

[stdout] Docker app's state test === RUN TestAppStatus apps: '[eclient]' state: 'RUNNING' secs: 1200 time: 2024-10-17T16:01:23.091644395Z out: appName eclient state changed to UNKNOWN time: 2024-10-17T16:01:26.606280165Z out: appName eclient state changed to RESOLVING_TAG time: 2024-10-17T16:01:29.607418568Z out: appName eclient state changed to DOWNLOAD_STARTED time: 2024-10-17T16:01:34.61087983Z out: appName eclient state changed to DOWNLOAD_STARTED (0%) time: 2024-10-17T16:01:35.611811745Z out: appName eclient state changed to DOWNLOAD_STARTED (100%) time: 2024-10-17T16:01:39.614899247Z out: appName eclient state changed to DOWNLOAD_STARTED (0%) time: 2024-10-17T16:01:46.620988939Z out: appName eclient state changed to DOWNLOAD_STARTED (4%) time: 2024-10-17T16:01:47.622274807Z out: appName eclient state changed to DOWNLOAD_STARTED (18%) time: 2024-10-17T16:01:50.625473951Z out: appName eclient state changed to DOWNLOAD_STARTED (25%) time: 2024-10-17T16:01:50.62549896Z out: appName eclient state changed to DOWNLOAD_STARTED (36%) time: 2024-10-17T16:01:52.627854851Z out: appName eclient state changed to DOWNLOAD_STARTED (50%) time: 2024-10-17T16:01:52.627905609Z out: appName eclient state changed to DOWNLOAD_STARTED (56%) time: 2024-10-17T16:01:53.629068492Z out: appName eclient state changed to DOWNLOAD_STARTED (64%) time: 2024-10-17T16:01:54.629684044Z out: appName eclient state changed to DOWNLOAD_STARTED (70%) time: 2024-10-17T16:01:55.630562403Z out: appName eclient state changed to DOWNLOAD_STARTED (81%) time: 2024-10-17T16:01:55.630585608Z out: appName eclient state changed to DOWNLOAD_STARTED (89%) time: 2024-10-17T16:01:58.63259795Z out: appName eclient state changed to DOWNLOAD_STARTED (96%) time: 2024-10-17T16:01:59.633813179Z out: appName eclient state changed to LOADING time: 2024-10-17T16:02:06.637357016Z out: appName eclient state changed to CREATING_VOLUME time: 2024-10-17T16:02:36.663186874Z out: appName eclient state changed to INSTALLED time: 2024-10-17T16:06:43.859132715Z out: appName eclient state changed to UNKNOWN time: 2024-10-17T16:06:48.863098208Z out: appName eclient state changed to INITIAL time: 2024-10-17T16:07:02.874687175Z out: appName eclient state changed to INSTALLED time: 2024-10-17T16:11:20.094446544Z out: appName eclient state changed to UNKNOWN time: 2024-10-17T16:11:27.100171128Z out: appName eclient state changed to INITIAL time: 2024-10-17T16:11:50.118881379Z out: appName eclient state changed to INSTALLED time: 2024-10-17T16:12:12.135846807Z out: appName eclient state changed to BOOTING time: 2024-10-17T16:12:14.137684566Z out: appName eclient state changed to HALTING: [description:"task broke with exit status 1" timestamp:{seconds:1729181531 nanos:321773310} severity:SEVERITY_ERROR] app_test.go:178: ASSERTION FAILED (2024-10-17T16:21:23.091962246Z): expected apps [eclient] in RUNNING state app_test.go:180: actual eclient: HALTING: [description:"task broke with exit status 1" timestamp:{seconds:1729181531 nanos:321773310} severity:SEVERITY_ERROR] app_test.go:182: history of states for eclient: app_test.go:184: state: no info from controller received in: 2024-10-17T16:01:23.08817257Z app_test.go:184: state: UNKNOWN received in: 2024-10-17T16:01:23.091641568Z app_test.go:184: state: RESOLVING_TAG received in: 2024-10-17T16:01:26.606276689Z app_test.go:184: state: DOWNLOAD_STARTED received in: 2024-10-17T16:01:29.607416494Z app_test.go:184: state: DOWNLOAD_STARTED (0%) received in: 2024-10-17T16:01:34.610875852Z app_test.go:184: state: DOWNLOAD_STARTED (100%) received in: 2024-10-17T16:01:35.611810311Z app_test.go:184: state: DOWNLOAD_STARTED (0%) received in: 2024-10-17T16:01:39.614897574Z app_test.go:184: state: DOWNLOAD_STARTED (4%) received in: 2024-10-17T16:01:46.620987236Z app_test.go:184: state: DOWNLOAD_STARTED (18%) received in: 2024-10-17T16:01:47.622274173Z app_test.go:184: state: DOWNLOAD_STARTED (25%) received in: 2024-10-17T16:01:50.625472178Z app_test.go
message 'Waiting for AppInstMetadata'
# Use eden.lim.test for access Infos with timewait 10m in background