Skip to content

allow airgapped switch network instances#2044

Merged
eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark:switch
Apr 27, 2021
Merged

allow airgapped switch network instances#2044
eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark:switch

Conversation

@eriknordmark
Copy link
Copy Markdown
Contributor

Somehow this had fallen off the truck; used to work a while back.

Signed-off-by: eriknordmark <erik@zededa.com>
@eriknordmark eriknordmark requested a review from rvs as a code owner April 26, 2021 21:30
Copy link
Copy Markdown
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add Eden test for this so that it doesn't fall off the truck again. @sadov @giggsoff any thoughts on this?

Other than that -- LGTM

@eriknordmark eriknordmark merged commit 3906e7d into lf-edge:master Apr 27, 2021
@sadov
Copy link
Copy Markdown
Contributor

sadov commented Apr 27, 2021

@rvs @nordmark how may look such test?

@rvs
Copy link
Copy Markdown
Contributor

rvs commented Apr 27, 2021

I think all you need to do @sadov is to create an Eden config according to the specification that this PR addressed -- you can also take a look at the commercial controller and what configs it creates when asked for an airgapped switch network.

@giggsoff
Copy link
Copy Markdown
Contributor

I added 'none' type of uplink into lf-edge/eden#593, so, will wait for merge.
@rvs do we have any plan of tagged version of EVE (with this commit) to update it inside Eden?

@rvs
Copy link
Copy Markdown
Contributor

rvs commented Apr 29, 2021

do we have any plan of tagged version of EVE (with this commit) to update it inside Eden?

well, this is in master -- hence getting released on the next train (6.5.0) that is expected to happen tomorrow @giggsoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants