-
Notifications
You must be signed in to change notification settings - Fork 175
more pkgs: no more package bumping #5219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
bc555e9
c8be975
aa349bc
cb405b3
5e96394
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
ignored: | ||
- DL3059 | ||
- DL3002 | ||
- DL3006 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve-acrn-kernel | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve-acrn | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
image: eve-alpine-base | ||
org: lfedge | ||
network: yes | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
image: eve-alpine | ||
org: lfedge | ||
network: yes | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,6 @@ config: | |
- /sys:/sys | ||
capabilities: | ||
- all | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,6 @@ | |
org: lfedge | ||
image: eve-bpftrace | ||
network: no | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve-bsp-imx | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve-cross-compilers | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,3 +30,6 @@ config: | |
devices: | ||
- path: all | ||
type: a | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,16 @@ | ||
# Copyright (c) 2025 Zededa, Inc. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
HOSTARCH := $(subst aarch64,arm64,$(subst x86_64,amd64,$(shell uname -m))) | ||
ZARCH ?= $(HOSTARCH) | ||
DOCKER_LIKE_LKT := ../../build-tools/bin/linuxkit pkg build --network --platforms linux/$(ZARCH) --dry-run --force ./ | tail -n1 | perl -pe 's/ buildx / /g' | ||
|
||
.PHONY: test | ||
|
||
test: | ||
docker run --privileged $(shell docker build --target=test -q .) go test -v | ||
build-docker-test-dependencies: | ||
make -C ../../ dnsmasq-cache-export-docker-load | ||
build-docker-test-build: build-docker-test-dependencies | ||
$(shell $(DOCKER_LIKE_LKT)) --load --target test | ||
|
||
test: build-docker-test-build | ||
docker run --privileged $(shell $(shell $(DOCKER_LIKE_LKT)) --load -q --target test) go test -v |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve-dnsmasq | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
org: lfedge | ||
image: eve-dom0-ztools | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,6 @@ config: | |
devices: | ||
- path: all | ||
type: a | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
image: eve | ||
org: lfedge | ||
|
||
buildArgs: | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,9 @@ | ||||||
# syntax=docker/dockerfile-upstream:1.5.0-rc2-labs | ||||||
|
||||||
ARG REL_HASH_LFEDGE_EVE_ALPINE | ||||||
ARG PLATFORM=generic | ||||||
|
||||||
FROM lfedge/eve-alpine:745ae9066273c73b0fd879c4ba4ff626a8392d04 AS build-base | ||||||
FROM ${REL_HASH_LFEDGE_EVE_ALPINE} AS build-base | ||||||
|
||||||
ARG TARGETARCH | ||||||
|
||||||
|
@@ -96,7 +98,7 @@ ADD https://hailo-hailort.s3.eu-west-2.amazonaws.com/Hailo8/${HAILO_FW_VERSION}/ | |||||
|
||||||
# generate initrd for Intel's and AMD's microcode | ||||||
# it makes sense only for x86_64 platform | ||||||
FROM --platform=${TARGETPLATFORM} lfedge/eve-alpine:745ae9066273c73b0fd879c4ba4ff626a8392d04 AS ucode-build-common | ||||||
FROM --platform=${TARGETPLATFORM} ${REL_HASH_LFEDGE_EVE_ALPINE} AS ucode-build-common | ||||||
RUN mkdir -p /boot /tmp/ucode/intel /tmp/ucode/amd /usr/share/licenses/ucode | ||||||
|
||||||
FROM ucode-build-common AS ucode-build-amd64 | ||||||
|
@@ -137,7 +139,7 @@ FROM ucode-build-common AS ucode-build-arm64 | |||||
FROM ucode-build-common AS ucode-build-riscv64 | ||||||
FROM ucode-build-${TARGETARCH} AS ucode-build | ||||||
|
||||||
FROM lfedge/eve-alpine:745ae9066273c73b0fd879c4ba4ff626a8392d04 AS compactor-common | ||||||
FROM ${REL_HASH_LFEDGE_EVE_ALPINE} AS compactor-common | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 142 correctly uses the parameterized ARG variable, but line 214 appears to be duplicating the same FROM statement with the same alias name 'compactor-common' changed to 'compactor-full'. This inconsistency should be reviewed to ensure the correct stage naming and purpose. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
ENTRYPOINT [] | ||||||
WORKDIR / | ||||||
COPY --from=build /lib/firmware/regulatory* /lib/firmware/ | ||||||
|
@@ -209,7 +211,7 @@ RUN if [ "$TARGETARCH" = "arm64" ]; then \ | |||||
fi | ||||||
|
||||||
|
||||||
FROM lfedge/eve-alpine:745ae9066273c73b0fd879c4ba4ff626a8392d04 AS compactor-full | ||||||
FROM ${REL_HASH_LFEDGE_EVE_ALPINE} AS compactor-full | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 142 correctly uses the parameterized ARG variable, but line 214 appears to be duplicating the same FROM statement with the same alias name 'compactor-common' changed to 'compactor-full'. This inconsistency should be reviewed to ensure the correct stage naming and purpose.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
# get all possible FW | ||||||
COPY --from=build /lib/firmware/ /lib/firmware/ | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,4 @@ org: lfedge | |
tag: "{{.Hash}}-generic" | ||
buildArgs: | ||
- PLATFORM=generic | ||
- REL_HASH_%=@lkt:pkgs:../* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,4 @@ org: lfedge | |
tag: "{{.Hash}}-evaluation" | ||
buildArgs: | ||
- PLATFORM=evaluation | ||
- REL_HASH_%=@lkt:pkgs:../* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, actually this change is not needed, as obviously
Dockerfile
is not using anyREL_HASH_*
, but I would like to add it anyways for two reasons:REL_HASH_*
to the Dockerfile then they might forget to add these lines to build.yml, so to keep the frustration low, let's add it alreadyfurthermore I don't expect any disadvantages from this