docs: fix removed assets in PR #379 affecting README.md #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there! Hey awesome project guys 🎉 , thanks for pushing the boundaries on this kind of apps for the open source community!
I am just adding a super tiny contribution here. I've just found your project and saw there were some missing images on the
README.md, I reviewed what lead to this and found that on yesterday's refactor some assets were gone leaving theREADME.mdwithout the app logo and app screenshot. This change only adds back the two (still in use) missing images.Logo (
docs/assets/hero.svg) was removed here https://github.com/lfnovo/open-notebook/pull/379/changes#diff-d472492a5896adbbaf42d18a8ec30330312057554c088ec96d92846f52aeae8b and is still in use in theREADME.mdhere https://github.com/lfnovo/open-notebook/blob/main/README.md?plain=1#L14Screenshot (
docs/assets/asset_list.png) was removed here https://github.com/lfnovo/open-notebook/pull/379/changes#diff-2e72d16dfe62b2e2a3c8740a8aff44744720a21879e5e696c57a2ebe6fce5bd7 and is still in use in theREADME.mdhere https://github.com/lfnovo/open-notebook/blob/main/README.md?plain=1#L55Greetings! 🙌
Related PR
#379
Type of Change
How Has This Been Tested?
Don't apply but tested it in markdown preview
Screenshots