Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job for Linux & Mac ARM64 too #1205

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented May 8, 2024

No description provided.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

martin-g commented May 8, 2024

Currently the build on Linux ARM64 fails with:

 gcc -c -g -Wall -O2 -Wc++-compat  -msse2 -DHAVE_KALLOC  ksw2_ll_sse.c -o ksw2_ll_sse.o
  gcc: error: unrecognized command-line option '-msse2'
  make: *** [Makefile:67: ksw2_ll_sse.o] Error 1
  Error: The process '/home/runner/work/_actions/uraimo/run-on-arch-action/v2/src/run-on-arch.sh' failed with exit code 2

https://github.com/martin-g/minimap2/actions/runs/9001617076/job/24728214278?pr=1

And for Mac ARM64: https://github.com/martin-g/minimap2/actions/runs/9001759602/job/24728641720

Same happens on Bioconda CI:

I am working on a fix!

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@hasindu2008
Copy link
Contributor

Are you giving
make arm_neon=1 aarch64=1

martin-g added 2 commits May 8, 2024 15:56
@martin-g
Copy link
Contributor Author

martin-g commented May 8, 2024

Thanks for the hint, @hasindu2008 !
The CI is fully green at my fork - https://github.com/martin-g/minimap2/actions/runs/9002250737

@martin-g martin-g changed the title Add CI job for Linux ARM64 too Add CI job for Linux & Mac ARM64 too May 8, 2024
@lh3 lh3 merged commit a0cbe2e into lh3:master Mar 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants