-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Enable GTM and CookieConsent for production #575
Conversation
|
Note I would like to check if the tag are delivered correctly, so let me merge by myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@@ -51,7 +51,7 @@ export default function ERDViewer({ | |||
errorObjects={errorObjects} | |||
/> | |||
</VersionProvider> | |||
{process.env.NEXT_PUBLIC_ENV_NAME !== 'production' && | |||
{process.env.NEXT_PUBLIC_ENV_NAME === 'production' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is there any reason not to display it in a preview or develpment environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview URL changes every time, so I thought Accept cookie
might be noisy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, it might be a good idea to make the tags ready to be accepted, and sent local or preview as well 🤔
Let me fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sasamuku
Could you implement the same approach as in this PR to pass the appEnv
information to GTM in ERD Web? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!!
Summary
Enable GTM and CookieConsent for production.
Note
I would like to check if the tag are delivered correctly, so let me merge by myself.
Related Issue
Changes
Testing
Other Information