Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Enable GTM and CookieConsent for production #575

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

sasamuku
Copy link
Member

@sasamuku sasamuku commented Jan 27, 2025

Summary

Enable GTM and CookieConsent for production.

Note

I would like to check if the tag are delivered correctly, so let me merge by myself.

Related Issue

Changes

Testing

Other Information

Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 92a601f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sasamuku
Copy link
Member Author

Note

I would like to check if the tag are delivered correctly, so let me merge by myself.

Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@@ -51,7 +51,7 @@ export default function ERDViewer({
errorObjects={errorObjects}
/>
</VersionProvider>
{process.env.NEXT_PUBLIC_ENV_NAME !== 'production' &&
{process.env.NEXT_PUBLIC_ENV_NAME === 'production' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is there any reason not to display it in a preview or develpment environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview URL changes every time, so I thought Accept cookie might be noisy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, it might be a good idea to make the tags ready to be accepted, and sent local or preview as well 🤔

Let me fix this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junkisai junkisai Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sasamuku
Could you implement the same approach as in this PR to pass the appEnv information to GTM in ERD Web? 🙏

https://github.com/liam-hq/liam/pull/581/files#diff-eb4b57e3ecbaf199bdd1827193ba86a8197289af7cf7ce28d3281c97d5939b71R69

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junkisai
okay, I've added 👍
92a601f

Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!

@sasamuku sasamuku added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 2c15d18 Jan 28, 2025
13 checks passed
@sasamuku sasamuku deleted the enable_cookie_consent_for_erd_web branch January 28, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants