Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql dependency in gql-format and gql-merge #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amannn
Copy link

@amannn amannn commented Oct 5, 2017

The specified graphql version in gql-merge and gql-format currently prevents me from upgrading my graphql version, as multiple versions of graphql in node_modules has some issues due to instanceof checks.

I checked the changelog of graphql and it looks like this library shouldn't be affected by breaking changes there.

I tried running your tests, but after lerna bootstrap I got an error: Error: Cannot find module 'gql-utils'. I'm not sure where that issue originates from.

Also flow finds some errors both in the graphql package as well as in your lib code. I added node_modules to your ignored flow files to get rid of the former ones, but I'm not sure where the others are coming from.

Also the lint task returns a bunch of errors – I don't think they are related to the upgrade of graphql, are they?


Another option would be to remove graphql from dependencies and move them to peerDependencies. WDYT?

@nfantone
Copy link

nfantone commented May 25, 2018

Having similar issue.

IMHO, graphql should definitely be declared as "peerDependency". Having it fixed as an internal dependency can only bring problems down the build pipe line for users.

@amannn amannn changed the title Update graphql dependency in gql-format and gql-merge. Update graphql dependency in gql-format and gql-merge Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants