Update graphql dependency in gql-format and gql-merge #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specified graphql version in gql-merge and gql-format currently prevents me from upgrading my
graphql
version, as multiple versions ofgraphql
in node_modules has some issues due toinstanceof
checks.I checked the changelog of
graphql
and it looks like this library shouldn't be affected by breaking changes there.I tried running your tests, but after
lerna bootstrap
I got an error:Error: Cannot find module 'gql-utils'
. I'm not sure where that issue originates from.Also flow finds some errors both in the
graphql
package as well as in your lib code. I addednode_modules
to your ignored flow files to get rid of the former ones, but I'm not sure where the others are coming from.Also the lint task returns a bunch of errors – I don't think they are related to the upgrade of graphql, are they?
Another option would be to remove
graphql
fromdependencies
and move them topeerDependencies
. WDYT?