-
Notifications
You must be signed in to change notification settings - Fork 242
Improve mobile-first dashboard and viewer layouts #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liaohch3
wants to merge
3
commits into
main
Choose a base branch
from
feat/mobile-first-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| Mobile-first UI evidence captured from a real Claude Code trace. | ||
|
|
||
| Source trace data: | ||
|
|
||
| - Temporary capture database: `/tmp/ct-mobile-evidence/traces.sqlite3` | ||
| - Session id: `86f7471f-4089-42a2-ac03-0f58a75de45f` | ||
| - Session model: `claude-sonnet-4-6` | ||
| - Session prompt: `Reply exactly: mobile-layout-real-trace-ok` | ||
| - API records: 2 | ||
|
|
||
| Trace capture: | ||
|
|
||
| ```bash | ||
| CLOUDTAP_DB=/tmp/ct-mobile-evidence/traces.sqlite3 \ | ||
| timeout 45s uv run python -m claude_tap \ | ||
| --tap-no-live \ | ||
| --tap-no-open \ | ||
| --tap-no-update-check \ | ||
| --tap-output-dir /tmp/ct-mobile-evidence/out \ | ||
| -- -p --tools '' --no-session-persistence --max-budget-usd 0.03 \ | ||
| 'Reply exactly: mobile-layout-real-trace-ok' | ||
| ``` | ||
|
|
||
| Local dashboard server: | ||
|
|
||
| ```bash | ||
| CLOUDTAP_DB=/tmp/ct-mobile-evidence/traces.sqlite3 \ | ||
| uv run claude-tap dashboard \ | ||
| --tap-output-dir /tmp/ct-mobile-evidence/out \ | ||
| --tap-live-port 33117 \ | ||
| --tap-no-open | ||
| ``` | ||
|
|
||
| Screenshots: | ||
|
|
||
| - `dashboard-mobile-list-320.png`: dashboard session cards at 320px. | ||
| - `dashboard-mobile-actions-320.png`: dashboard mobile card action row at 320px. | ||
| - `dashboard-mobile-list-375.png`: dashboard session cards at 375px. | ||
| - `dashboard-tablet-list-768.png`: tablet-width dashboard session cards at 768px. | ||
| - `dashboard-desktop-table-1440.png`: desktop dashboard table at 1440px. | ||
| - `viewer-mobile-list-320.png`: standalone viewer list state at 320px. | ||
| - `viewer-mobile-list-375.png`: standalone viewer list state at 375px. | ||
| - `viewer-mobile-detail-320.png`: standalone viewer detail state at 320px. | ||
| - `viewer-mobile-detail-375.png`: standalone viewer detail state at 375px. | ||
| - `viewer-desktop-detail-1440.png`: standalone viewer detail state at 1440px. | ||
|
|
||
| Capture assertions: | ||
|
|
||
| - `/api/sessions` returned exactly the generated session. | ||
| - Every captured viewport reported page-level `overflowX <= 2`. | ||
| - Dashboard mobile refresh control renders as an icon with `aria-label="Refresh"`, not a literal `R`. | ||
| - Viewer mobile detail action buttons stay inside the action bar, including `Diff with Prev`. | ||
| - Viewer detail evidence keeps long `System Prompt` and `Messages` sections collapsed to avoid exposing local paths or private prompt context in public PR screenshots. | ||
|
|
||
| Manual screenshot review: | ||
|
|
||
| - No mobile screenshot shows clipped primary actions. | ||
| - No screenshot shows synthetic or mock trace data. | ||
| - No screenshot exposes secrets, tokens, local email addresses, or expanded long prompt context. | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This evidence README points reviewers to a temporary
/tmp/ct-mobile-evidence/traces.sqlite3capture, but the repo policy inAGENTS.mdrequires evidence to use real trace data from.traces/. Because/tmpdata is not committed or reproducible by other reviewers, the mobile screenshots cannot be validated against the stated source trace and the evidence becomes misleading for this UI change. Move or reference the real trace database under.traces/and update the capture commands accordingly.Useful? React with 👍 / 👎.