fix: correct issue of data being null/empty (#77)

liatrio · Aug 20, 2024 · db95192 · db95192
1 parent 5830bbc
commit db95192
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 10 deletions.
diff --git a/src/ChangeFailureRate.tsx b/src/ChangeFailureRate.tsx
@@ -79,8 +79,13 @@ const ChangeFailureRate : React.FC<ChartProps> = (props: ChartProps) => {
     const maxBarWidth = (1 / ((endDate.getTime() - startDate.getTime()) / (1000 * 60 * 60 * 24))) * 33 + "%"
 
     const organizeData = (data: DoraRecord[]) => {
-        if(data.length === 0) {
+        if(!data || data.length === 0) {
             setNoData(true)
+            setRepositories([])
+            setGraphData([])
+            setColors([])
+            setLoading(false)
+            return
         }
 
         const extractedData = extractChangeFailureRatePerDay(props, data)

diff --git a/src/ChangeLeadTime.tsx b/src/ChangeLeadTime.tsx
@@ -51,8 +51,12 @@ const ChangeLeadTime : React.FC<ChartProps> = (props: ChartProps) => {
     const ticks = generateTicks(startDate, endDate, 5)
 
     const organizeData = useCallback((data: DoraRecord[]) => {
-        if(data.length === 0) {
+        if(!data || data.length === 0) {
             setNoData(true)
+            setGraphData(new Map<string, DoraRecord[]>())
+            setColors([])
+            setLoading(false)
+            return
         }
 
         const extractedData = extractChangeLeadTimePerRepository(data)

diff --git a/src/DeploymentFrequency.tsx b/src/DeploymentFrequency.tsx
@@ -69,8 +69,14 @@ const DeploymentFrequency : React.FC<ChartProps> = (props: ChartProps) => {
     const maxBarWidth = (1 / ((endDate.getTime() - startDate.getTime()) / (1000 * 60 * 60 * 24))) * 33 + "%"
 
     const organizeData = (data: DoraRecord[]) => {
-        if(data.length === 0) {
+        if(!data || data.length === 0) {
             setNoData(true)
+            setRepositories([])
+            setGraphData([])
+            setColors([])
+            setLoading(false)
+            setMaxDeploys(0)
+            return
         }
 
         const [extractedData, deploys] = extractDeploymentsPerDay(props, data)

diff --git a/src/Helpers.tsx b/src/Helpers.tsx
@@ -215,8 +215,17 @@ export const dateToUtc = (date: Date, dateOnly: boolean = true) => {
 }
 
 export const fetchData = async (props: ChartProps, onSuccess: (data: any) => void, onFailure?: (data: any) => void) => {
-  if(props.data) {
+  if(!props.api && !props.data) {
+    onSuccess([])
+    return
+  } else if(props.data) {
     let data = props.data
+
+    if(data.records && data.records.length === 0) {
+      onSuccess([])
+      return
+    }
+
     let parsedData: any = {}
 
     if(typeof data === "string") {
@@ -236,10 +245,6 @@ export const fetchData = async (props: ChartProps, onSuccess: (data: any) => voi
     return
   }
 
-  if(!props.api) {
-    return
-  }
-
   const start = props.start ? dateToUtc(props.start) : getDateDaysInPastUtc(31)
   const end = props.end ? dateToUtc(props.end) : getDateDaysInPastUtc(1)
 

diff --git a/src/RecoverTime.tsx b/src/RecoverTime.tsx
@@ -76,8 +76,14 @@ const RecoverTime: React.FC<ChartProps> = (props: ChartProps) => {
   const ticks = generateTicks(startDate, endDate, 5);
 
   const organizeData = (data: DoraRecord[]) => {
-    if (data.length === 0) {
-      setNoData(true);
+    if (!data || data.length === 0) {
+      setNoData(true)
+      setRepositories([])
+      setGraphData([])
+      setColors([])
+      setLoading(false)
+      setYLabel(" hrs")
+      return
     }
 
     const extractedData = extractAvgRecoverTimePerDay(props, data);