Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing AC_CHECK_FILE from slepc.m4 #17

Merged
merged 1 commit into from
Dec 19, 2012

Conversation

jwpeterson
Copy link
Member

Can someone who actually uses SLEPc (or has a buildbot configuration for it) try out this branch and let me know if it still works? Thanks...

AC_CHECK_FILE does not play nicely with cross-compiling.
@buildhive
Copy link

libMesh - C++ Finite Element Library » libmesh #83 SUCCESS
This pull request looks good
(what's this?)

@benkirk
Copy link
Member

benkirk commented Dec 18, 2012

Sure - if not tonight first thing tomorrow.

-Ben

On Dec 18, 2012, at 4:21 PM, "jwpeterson" <[email protected]mailto:[email protected]> wrote:

Can someone who actually uses SLEPc (or has a buildbot configuration for it) try out this branch and let me know if it still works? Thanks...


You can merge this Pull Request by running:

git pull https://github.com/jwpeterson/libmesh slepc_check_header

Or view, comment on, or merge it at:

#17

Commit Summary

  • Removing AC_CHECK_FILE from slepc.m4

File Changes

  • M m4/slepc.m4 (44)

Patch Links


Reply to this email directly or view it on GitHubhttps://github.com//pull/17.

@jwpeterson
Copy link
Member Author

Thanks. Forgot to mention: new configure script is not included in the patch, so you'll have to bootstrap to try out the changes.

@benkirk
Copy link
Member

benkirk commented Dec 19, 2012

This works for me.

BTW, what's the cleanest way to get back to a pristine master after I pull a single file like this?

I can check out the original again from master, but that still shows me with local mods...

-Ben

@jwpeterson
Copy link
Member Author

BTW, what's the cleanest way to get back to a pristine master after I pull a single file like this?

Hmm if you pulled it down into master, you can

git reset --hard HEAD~1

To get rid of it...

John

On Dec 18, 2012, at 5:19 PM, "Benjamin S. Kirk" [email protected] wrote:

This works for me.

BTW, what's the cleanest way to get back to a pristine master after I pull a single file like this?

I can check out the original again from master, but that still shows me with local mods...

-Ben


Reply to this email directly or view it on GitHub.

@benkirk
Copy link
Member

benkirk commented Dec 19, 2012

That worked, thanks!

If you want to merge these that's fine with me - it'll give my builbot a chance to see them in master and I can fix any issues tomorrow...

@jwpeterson
Copy link
Member Author

Ok will do that after the kids are in bed.

John

On Dec 18, 2012, at 6:28 PM, "Benjamin S. Kirk" [email protected] wrote:

That worked, thanks!

If you want to merge these that's fine with me - it'll give my builbot a chance to see them in master and I can fix any issues tomorrow...


Reply to this email directly or view it on GitHub.

jwpeterson added a commit that referenced this pull request Dec 19, 2012
Removing AC_CHECK_FILE from slepc.m4
@jwpeterson jwpeterson merged commit 65936f1 into libMesh:master Dec 19, 2012
@jwpeterson jwpeterson deleted the slepc_check_header branch December 19, 2012 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants