Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intergration of new transpiler with C++ full support #749

Closed
wants to merge 70 commits into from
Closed

Intergration of new transpiler with C++ full support #749

wants to merge 70 commits into from

Conversation

vyast-softserveinc
Copy link

Description

This pull request is aimed for integration occa-transpiler library for providing full C++ support under the OCCA

Added:

  • option for switching between old & new transpiler transpiler-version
  • minor code improvments

vyast-softserveinc and others added 30 commits March 5, 2024 19:43
@vyast-softserveinc
integrate oklt transpiler to occa cli
02bf328
@vyast-softserveinc
added transpiler version command & selection for launcherDevice backends
83d0d1d
@vyast-softserveinc
added adhock impl for usage oklt transpiler with old launcher generation
aa48b41
@deukhyun-cha @kris-rowe
Increase the maximum number of kernel arguments to 128 (libocca#709)
27fff94
@rakesroy @kris-rowe
Change HIP_PLATFORM from HCC to AMD and NVCC to NVIDIA (libocca#713)
3b86874 
Co-authored-by: Rakesh Roy <[email protected]>
@kris-rowe
Hotfix GitHub actions.
5b0213f 
Clang 12 is no longer available in GitHub's Ubutntu 22.04 runner.
@noelchalmers @kris-rowe
Resize the argument buffer to be able to fit large arguments passed b…
eff5266 
…y value (libocca#714)
@noelchalmers @kris-rowe
[HIP] Bump supported HIP versions to v4.2 or later (libocca#715)
c779086 
* [HIP] Remove some compile-time backward compatibility switches

* [HIP] Bump supported HIP version to v4.2 or later
@deukhyun-cha @kris-rowe
Allow user to define the maximum number of kernel arguments and autom…
d6e71e7 
…atically run script to generate the codes (libocca#718)
@kris-rowe
Hotfix GitHub Actions
18f75c1 
The environment variable `SYCL_DEVICE_FILTER` used by the oneAPI SDK is deprecated, causing some tests to fail.
@kris-rowe
Remove dpcpp from modes tested with inline kernel example on GitHub (l…
3cb365f 
…ibocca#719)
@kris-rowe
Sets OCCA_<MODE>_ENABLED in CMake parent scope. (libocca#720)
b173541 
Intended for CMake builds which add occa as a subdirectory.
@kris-rowe
Correctly sync all streams in device::finishAll(). (libocca#723)
c824a2a
@kris-rowe
Ensure all work is complete on device before freeing memory. (libocca…
8ad756c 
…#724)
@AljenU @kris-rowe
cmake: Small fix to prevent empty module path (libocca#694)
0187d1d
@deukhyun-cha @kris-rowe
Update cmake to generate kernel-arguments-related codes only if neces…
a8a2567 
…sary. Add an option to only generate jit kernel related code for the new number of kernel arguments and leave others to the default value for compile time efficiency (libocca#725)
@kris-rowe
Fixes corruption of memory datatypes caused by short circuit logic in…
d05f677 
… `modeMemory_t::slice` (libocca#727)
@kris-rowe
Refactor OpenCL mode and update CI testing (libocca#730)
7791a79 
* Refactor OpenCL utilities and device creation.

* Update OpenCL default device type.

* Only run math function test for active modes.

* Update GitHub workflows.

* Remove OpenCL from math function tests.
@kris-rowe
Set SYCL subgroup size via kernel property or @simd_length attribut…
1b38d46 
…e. (libocca#726)
@kris-rowe
**BREAKING** Make memory copies data type aware for consistency. (lib…
7d9d089 
…occa#728)
@kris-rowe
**BREAKING** Return the number of dtype entries from `memory::size(…
aca6151 
…)`. (libocca#711)
@noelchalmers @kris-rowe
Initial support for compiler attribute statements (libocca#729)
a496e1b
@kris-rowe
Prefix CMake build options with OCCA (libocca#733)
b2df8b3
@kris-rowe
Update year.
e91ca2f
@kris-rowe
Update version number.
246ee3b
@kris-rowe
Update minimum CMake version listed in docs.
bfdf49f
@kris-rowe
Rename memcpy free function length parameter to reflect changes to
de0064b 
`occa::memory`.
@kris-rowe
Move memoryPool from occa::experimental to occa namespace
ab48248
@nsoborin @kris-rowe
cmake: expose CUDA::cuda_driver dependency in use
1f6c540 
Without this, CUDA::cuda_driver target is not linked to libocca during
consumption and as a result there is a build problem: libcuda.so cannot
be found. This occurs on machines which do not have CUDA lib default,
 compiler included libraries (e.g. in /lib64)
@barracuda156 @kris-rowe
sys.cpp: add missing AvailabilityMacros.h
b4495ee
@vyast-softserveinc
Copy link
Author

vyast-softserveinc commented Apr 2, 2024 •
edited
Loading

@kris-rowe is it possible to setup the llvm 17 for the images?
This update depends on the clang 17. The reference for setup from the occa-transpiler is the following:
https://github.com/libocca/occa-transpiler/tree/devel?tab=readme-ov-file#setup-llvm

@vyast-softserveinc
integrate oklt transpiler to occa cli
89e9c97
@vyast-softserveinc
added transpiler version command & selection for launcherDevice backends
857a95c
@vyast-softserveinc
added adhock impl for usage oklt transpiler with old launcher generation
ad7411b
@vyast-softserveinc
move all v3 methods for include/defines & meta generation as separate…
881d669 
… functions
@vyast-softserveinc
added unsigned long support as the built-in type
41c9d6b
@vyast-softserveinc
added support of unsigned long type as built-in
6a998d3
@vyast-softserveinc
remove unused file from examples
a145005
@vyast-softserveinc
remove another unused cpp from examples
63d4da5
@vyast-softserveinc
remove commented code
65c9350
@vyast-softserveinc
added integration with cmake CPM
31a78a1
@vyast-softserveinc
remove commented cmake instructions
36f6dcf
@vyast-softserveinc
update rev for occa-transpiler
5f97b85
@vyast-softserveinc
added OCCA_INCLUDE_DIR to passing values to occa-transpiler
668e5ce
@vyast-softserveinc
fix for backed parameter was hardcoded for testing
e7044e6
@vyast-softserveinc
remove redundant comment
3aec4af
@vyast-softserveinc
Merge branch 'integrated_oklt_transpiler' of https://github.com/vyast…
ee4a8ea 
…-softserveinc/occa into integrated_oklt_transpiler
@kris-rowe
Copy link
Member

@kris-rowe is it possible to setup the llvm 17 for the images? This update depends on the clang 17. The reference for setup from the occa-transpiler is the following: https://github.com/libocca/occa-transpiler/tree/devel?tab=readme-ov-file#setup-llvm

We are doing something similar in the GitHub actions to test the oneAPI compilers (here). Does it make sense to test the transpiler for all of the configurations we currently do or only a subset?

@vyast-softserveinc
Copy link
Author

By the last commits I made optional building . So I think it would be enough to make it for single configuration.

@vyast-softserveinc
Copy link
Author

This PR is out of date. new implementation with the #756 is provided instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kris-rowe kris-rowe Awaiting requested review from kris-rowe

@noelchalmers noelchalmers Awaiting requested review from noelchalmers

@tcew tcew Awaiting requested review from tcew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vyast-softserveinc @kris-rowe @deukhyun-cha @rakesroy @noelchalmers @AljenU @nsoborin @barracuda156