Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix flaky TestStreamWriteDeadlineAsync #2579

Closed
wants to merge 1 commit into from

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Sep 21, 2023

No description provided.

@sukunrt sukunrt force-pushed the sukun/webrtc-flaky branch 2 times, most recently from c1c01c8 to f5ebfe4 Compare September 22, 2023 06:36
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is necessary. We already have a 5x timeout on CI. Why is that not sufficient?

It seems like we have two ways here that are trying to achieve the same thing.

@sukunrt
Copy link
Member Author

sukunrt commented Sep 24, 2023

I'll rethink the whole test.

I'm not sure why we have the first extension of timeout in CI especially to a value as high as 500ms.

The test checks that when we set the deadline to timeout duration it does eventually give the deadline exceeded error. Then in the last check it checks that this error was provided after a sufficient duration. The last check defines sufficient currently as 1.5 * timeout. I changed it to 3 * timeout since it was flaking on windows as the test took more than 750 ms(500 * 1.5) and it generally took less than 900ms(as per my memory).
I am not convinced that the first extension of timeout makes sense. Why should we have to set deadline for 500ms when we are in CI?

@p-shahi
Copy link
Member

p-shahi commented Oct 16, 2023

What's the status of this PR - are we targeting it for the release or is it a nice to have?

@marten-seemann
Copy link
Contributor

@Sukun says this test hasn't failed in a while. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants