[DO NOT MERGE] fix(dcutr): fix roles in tcp simultaneous connection #3044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did the opposite thing of what the spec says to do. This meant that we would fail to hole-punch with rust nodes because both sides would attempt to be the dialer.
The spec is a bit confusing since roles get flipped in the middle. But essentially:
/libp2p/dcutr
protocol.This means the side handling the stream is the client, and the side initiating the stream should be the server.
Rollout:
We can't merge this until we figure out how we are going to roll this out.
This change, as is, is a backwards incompatible change. It would cause TCP hole punching to fail between go-libp2p nodes prior to this change and those after.
Let's discuss the rollout strategy here.