Skip to content

fix(derive): Release breaking change as v0.31.0 #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxinden merged 3 commits into from
Nov 29, 2022
Merged

fix(derive): Release breaking change as v0.31.0 #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b05674
fix(derive): Release breaking change as v0.31.0
mxinden Nov 29, 2022
9b166a3
swarm/Cargo: Don't specify libp2p-swarm-derive version
mxinden Nov 29, 2022
c39e6e7
Apply suggestions from code review
mxinden Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swarm-derive/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 0.30.2
# 0.31.0

- Replace `NetworkBehaviour` Derive macro deprecated `inject_*` method implementations
with the new `on_swarm_event` and `on_connection_handler_event`.
Expand Down
4 changes: 2 additions & 2 deletions swarm-derive/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
name = "libp2p-swarm-derive"
edition = "2021"
rust-version = "1.60.0"
description = "Procedural macros of libp2p-core"
version = "0.30.2"
description = "Procedural macros of libp2p-swarm"
version = "0.31.0"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand Down
4 changes: 4 additions & 0 deletions swarm/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.41.1

- Update to `libp2p-swarm-derive` `v0.31.0`.

# 0.41.0

- Update to `libp2p-core` `v0.38.0`.
Expand Down
6 changes: 3 additions & 3 deletions swarm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p-swarm"
edition = "2021"
rust-version = "1.62.0"
description = "The libp2p swarm"
version = "0.41.0"
version = "0.41.1"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand All @@ -17,7 +17,7 @@ futures = "0.3.1"
futures-timer = "3.0.2"
instant = "0.1.11"
libp2p-core = { version = "0.38.0", path = "../core" }
libp2p-swarm-derive = { version = "0.30.2", path = "../swarm-derive", optional = true }
libp2p-swarm-derive = { version = "0.31.0", path = "../swarm-derive", optional = true }
log = "0.4"
pin-project = "1.0.0"
rand = "0.8"
Expand Down Expand Up @@ -46,7 +46,7 @@ libp2p-identify = { path = "../protocols/identify" }
libp2p-kad = { path = "../protocols/kad" }
libp2p-ping = { path = "../protocols/ping" }
libp2p-plaintext = { path = "../transports/plaintext" }
libp2p-swarm-derive = { version = "0.30.2", path = "../swarm-derive" }
Copy link
Member Author

@mxinden mxinden Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version was introduced in https://github.com/libp2p/rust-libp2p/pull/3055/files#r1034571199. @thomaseizinger was that a deliberate choice or an oversight?

Copy link
Contributor

@thomaseizinger thomaseizinger Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An oversight! Thanks for fixing it!

libp2p-swarm-derive = { path = "../swarm-derive" }
libp2p-yamux = { path = "../muxers/yamux" }
quickcheck = { package = "quickcheck-ext", path = "../misc/quickcheck-ext" }
void = "1"
Expand Down