feat!: Remove simple::SimpleProtocol#3191
Merged
mxinden merged 7 commits intolibp2p:masterfrom Dec 9, 2022
Merged
Conversation
Due to lack of usage, remove the `simple::SimpleProtocol`. Users may look at `libp2p::core::upgrade` for alternatives.
Contributor
Uhm, good question. This discussion discussion suggests |
thomaseizinger
approved these changes
Dec 4, 2022
Co-authored-by: João Oliveira <hello@jxs.pt>
Member
Author
|
Testground failure is due to a rename: See #2647 (comment) for |
4 tasks
Contributor
Fix is here: #3203 |
Contributor
|
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
Member
Author
|
For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to lack of usage, remove the
simple::SimpleProtocol. Users may look atlibp2p::core::upgradefor alternatives.Notes
Discovered through @umgefahren's
masterdocs (#3126).Links to any relevant issues
Open Questions
Change checklist