Skip to content

fix(dcutr): rename error types to bypass cargo-semver-checks hickup #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 12 commits into from
Dec 13, 2022
Merged

fix(dcutr): rename error types to bypass cargo-semver-checks hickup #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fa8151e
Fix `cargo-semver-checks` hickup
thomaseizinger Dec 8, 2022
b805939
Bump version in manifest and update changelog
thomaseizinger Dec 8, 2022
9f70789
Actually make it backwards-compatible
thomaseizinger Dec 8, 2022
4335ce1
Don't export more symbols than necessary
thomaseizinger Dec 9, 2022
9383624
Rename type back
thomaseizinger Dec 11, 2022
606047e
Merge branch 'master' into fix-semver-check-hickup
thomaseizinger Dec 11, 2022
406f62d
Update protocols/dcutr/CHANGELOG.md
thomaseizinger Dec 11, 2022
012ad58
Undo bump in `misc/metrics`
thomaseizinger Dec 11, 2022
21fb9b4
Undo bump and changelog entry in root lib
thomaseizinger Dec 11, 2022
5c1ec73
Make change more minimal
thomaseizinger Dec 11, 2022
0da964d
Merge branch 'fix-semver-check-hickup' of github.com:libp2p/rust-libp…
thomaseizinger Dec 11, 2022
a926aa1
Merge branch 'master' into fix-semver-check-hickup
thomaseizinger Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions protocols/dcutr/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

- Update to `libp2p-swarm` `v0.42.0`.

- Declare `InboundUpgradeError` and `OutboundUpgradeError` as type aliases instead of renames.
This is a workaround for a missing feature in `cargo semver-checks`. See [PR 3213].

[PR 3213]: https://github.com/libp2p/rust-libp2p/pull/3213

# 0.8.0

- Update to `prost-codec` `v0.3.0`.
Expand Down
10 changes: 4 additions & 6 deletions protocols/dcutr/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,11 @@
pub mod behaviour;
mod handler;
mod protocol;

pub use protocol::{
inbound::UpgradeError as InboundUpgradeError, outbound::UpgradeError as OutboundUpgradeError,
PROTOCOL_NAME,
};

#[allow(clippy::derive_partial_eq_without_eq)]
mod message_proto {
include!(concat!(env!("OUT_DIR"), "/holepunch.pb.rs"));
}

pub use protocol::PROTOCOL_NAME;
pub type InboundUpgradeError = protocol::inbound::UpgradeError;
pub type OutboundUpgradeError = protocol::outbound::UpgradeError;