fix(identify): check actual port reuse instead of original intent by ErakhtinB · Pull Request #6096 · libp2p/rust-libp2p

ErakhtinB · 2025-07-09T11:53:04Z

When PortUse::Reuse fails and falls back to ephemeral ports, detect this by comparing observed ports with listening ports rather than tracking the original PortUse intent.

Fixes #5820

Description

Notes & open questions

Change checklist

I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
A changelog entry has been made in the appropriate crates

When PortUse::Reuse fails and falls back to ephemeral ports, detect this by comparing observed ports with listening ports rather than tracking the original PortUse intent. Fixes libp2p#5820

elenaf9

Thanks for the PR and sorry for the (very) long delay!

Two nits, rest LGTM!

…ix-ephemeral-port-address-translation

Approvals have been dismissed because the PR was updated after the send-it label was applied.

mergify · 2026-09-09T13:18:51Z

Merge Queue Status

✅ Entered queue — 2026-09-09 13:18 UTC · Rule: default · triggered by rule Add send-it labeled PRs to merge queue
✅ Checks skipped · PR is already up-to-date
✅ Merged — 2026-09-09 13:19 UTC · at 164405ef77d80c0c5adf06e0a89b452bfe04bae8 · squash

This pull request spent 1 minute 11 seconds in the queue, including 12 seconds running CI.

Required conditions to merge

#review-threads-unresolved = 0 [🛡 GitHub branch protection]
- fix(identify): check actual port reuse instead of original intent #6096
github-review-approved [🛡 GitHub branch protection]
- fix(identify): check actual port reuse instead of original intent #6096
any of [🛡 GitHub branch protection]:
- check-success = Check rustdoc intra-doc links
- check-neutral = Check rustdoc intra-doc links
- check-skipped = Check rustdoc intra-doc links
any of [🛡 GitHub branch protection]:
- check-success = rustfmt
- check-neutral = rustfmt
- check-skipped = rustfmt
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-metrics
- check-neutral = Test libp2p-metrics
- check-skipped = Test libp2p-metrics
any of [🛡 GitHub branch protection]:
- check-success = Compile on x86_64-apple-darwin
- check-neutral = Compile on x86_64-apple-darwin
- check-skipped = Compile on x86_64-apple-darwin
any of [🛡 GitHub branch protection]:
- check-success = Compile on x86_64-pc-windows-msvc
- check-neutral = Compile on x86_64-pc-windows-msvc
- check-skipped = Compile on x86_64-pc-windows-msvc
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-yamux
- check-neutral = Test libp2p-yamux
- check-skipped = Test libp2p-yamux
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm
- check-neutral = Test libp2p-swarm
- check-skipped = Test libp2p-swarm
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-mdns
- check-neutral = Test libp2p-mdns
- check-skipped = Test libp2p-mdns
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-relay
- check-neutral = Test libp2p-relay
- check-skipped = Test libp2p-relay
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-uds
- check-neutral = Test libp2p-uds
- check-skipped = Test libp2p-uds
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-rendezvous
- check-neutral = Test libp2p-rendezvous
- check-skipped = Test libp2p-rendezvous
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p
- check-neutral = Test libp2p
- check-skipped = Test libp2p
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-noise
- check-neutral = Test libp2p-noise
- check-skipped = Test libp2p-noise
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-gossipsub
- check-neutral = Test libp2p-gossipsub
- check-skipped = Test libp2p-gossipsub
any of [🛡 GitHub branch protection]:
- check-success = Test rw-stream-sink
- check-neutral = Test rw-stream-sink
- check-skipped = Test rw-stream-sink
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-dns
- check-neutral = Test libp2p-dns
- check-skipped = Test libp2p-dns
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-floodsub
- check-neutral = Test libp2p-floodsub
- check-skipped = Test libp2p-floodsub
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm-derive
- check-neutral = Test libp2p-swarm-derive
- check-skipped = Test libp2p-swarm-derive
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-pnet
- check-neutral = Test libp2p-pnet
- check-skipped = Test libp2p-pnet
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-tls
- check-neutral = Test libp2p-tls
- check-skipped = Test libp2p-tls
any of [🛡 GitHub branch protection]:
- check-success = Test multistream-select
- check-neutral = Test multistream-select
- check-skipped = Test multistream-select
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-kad
- check-neutral = Test libp2p-kad
- check-skipped = Test libp2p-kad
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-core
- check-neutral = Test libp2p-core
- check-skipped = Test libp2p-core
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-tcp
- check-neutral = Test libp2p-tcp
- check-skipped = Test libp2p-tcp
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-websocket
- check-neutral = Test libp2p-websocket
- check-skipped = Test libp2p-websocket
any of [🛡 GitHub branch protection]:
- check-success = IPFS Integration tests
- check-neutral = IPFS Integration tests
- check-skipped = IPFS Integration tests
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-identify
- check-neutral = Test libp2p-identify
- check-skipped = Test libp2p-identify
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-dcutr
- check-neutral = Test libp2p-dcutr
- check-skipped = Test libp2p-dcutr
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-unknown-emscripten
- check-neutral = Compile on wasm32-unknown-emscripten
- check-skipped = Compile on wasm32-unknown-emscripten
any of [🛡 GitHub branch protection]:
- check-success = Compile with select features (mdns tcp dns tokio)
- check-neutral = Compile with select features (mdns tcp dns tokio)
- check-skipped = Compile with select features (mdns tcp dns tokio)
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-request-response
- check-neutral = Test libp2p-request-response
- check-skipped = Test libp2p-request-response
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-unknown-unknown
- check-neutral = Compile on wasm32-unknown-unknown
- check-skipped = Compile on wasm32-unknown-unknown
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-mplex
- check-neutral = Test libp2p-mplex
- check-skipped = Test libp2p-mplex
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-ping
- check-neutral = Test libp2p-ping
- check-skipped = Test libp2p-ping
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-plaintext
- check-neutral = Test libp2p-plaintext
- check-skipped = Test libp2p-plaintext
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-autonat
- check-neutral = Test libp2p-autonat
- check-skipped = Test libp2p-autonat
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-quic
- check-neutral = Test libp2p-quic
- check-skipped = Test libp2p-quic
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-webrtc
- check-neutral = Test libp2p-webrtc
- check-skipped = Test libp2p-webrtc
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-identity
- check-neutral = Test libp2p-identity
- check-skipped = Test libp2p-identity
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-allow-block-list
- check-neutral = Test libp2p-allow-block-list
- check-skipped = Test libp2p-allow-block-list
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-swarm-test
- check-neutral = Test libp2p-swarm-test
- check-skipped = Test libp2p-swarm-test
any of [🛡 GitHub branch protection]:
- check-success = Check for changes in proto files
- check-neutral = Check for changes in proto files
- check-skipped = Check for changes in proto files
any of [🛡 GitHub branch protection]:
- check-success = Ensure that `Cargo.lock` is up-to-date
- check-neutral = Ensure that `Cargo.lock` is up-to-date
- check-skipped = Ensure that `Cargo.lock` is up-to-date
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-connection-limits
- check-neutral = Test libp2p-connection-limits
- check-skipped = Test libp2p-connection-limits
any of [🛡 GitHub branch protection]:
- check-success = examples
- check-neutral = examples
- check-skipped = examples
any of [🛡 GitHub branch protection]:
- check-success = Run all WASM tests
- check-neutral = Run all WASM tests
- check-skipped = Run all WASM tests
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-memory-connection-limits
- check-neutral = Test libp2p-memory-connection-limits
- check-skipped = Test libp2p-memory-connection-limits
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-webtransport-websys
- check-neutral = Test libp2p-webtransport-websys
- check-skipped = Test libp2p-webtransport-websys
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-perf
- check-neutral = Test libp2p-perf
- check-skipped = Test libp2p-perf
any of [🛡 GitHub branch protection]:
- check-success = Compile with MSRV
- check-neutral = Compile with MSRV
- check-skipped = Compile with MSRV
any of [🛡 GitHub branch protection]:
- check-success = manifest_lint
- check-neutral = manifest_lint
- check-skipped = manifest_lint
any of [🛡 GitHub branch protection]:
- check-success = Test libp2p-server
- check-neutral = Test libp2p-server
- check-skipped = Test libp2p-server
any of [🛡 GitHub branch protection]:
- check-success = Compile on wasm32-wasip1
- check-neutral = Compile on wasm32-wasip1
- check-skipped = Compile on wasm32-wasip1

fix(identify): check actual port reuse instead of original intent

11fa89f

When PortUse::Reuse fails and falls back to ephemeral ports, detect this by comparing observed ports with listening ports rather than tracking the original PortUse intent. Fixes libp2p#5820

ErakhtinB mentioned this pull request Jul 17, 2025

Address translation doesn't work correctly with non-reused ephemeral ports #5820

Closed

elenaf9 reviewed Oct 21, 2025

View reviewed changes

Comment thread protocols/identify/src/behaviour.rs Outdated

Comment thread protocols/identify/src/behaviour.rs Outdated

Comment thread protocols/identify/src/behaviour.rs

elenaf9 mentioned this pull request Apr 28, 2026

ConnectedPoint.port_use reports Reuse when dial actually used an ephemeral port #6393

Closed

elenaf9 added 3 commits April 28, 2026 09:01

Merge branch 'master' of https://github.com/libp2p/rust-libp2p into f…

93e61ee

…ix-ephemeral-port-address-translation

identify: compare protocol type for ports

414f66f

identify: add CHANGELOG entry

80ad8cc

elenaf9 previously approved these changes Apr 28, 2026

View reviewed changes

elenaf9 added the send-it label Apr 28, 2026

Merge branch 'master' into fix-ephemeral-port-address-translation

c6ee582

jxs approved these changes Sep 9, 2026

View reviewed changes

mergify Bot added the queued label Sep 9, 2026

mergify Bot merged commit 164405e into libp2p:master Sep 9, 2026
67 of 70 checks passed

mergify Bot removed the queued label Sep 9, 2026

Navigation Menu

Uh oh!

fix(identify): check actual port reuse instead of original intent - #6096

fix(identify): check actual port reuse instead of original intent#6096
mergify[bot] merged 5 commits into
libp2p:masterfrom
ErakhtinB:fix-ephemeral-port-address-translation

ErakhtinB commented Jul 9, 2025

Uh oh!

elenaf9 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ErakhtinB commented Jul 9, 2025

Description

Notes & open questions

Change checklist

Uh oh!

elenaf9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elenaf9 left a comment •

edited

Loading

mergify Bot commented Sep 9, 2026 •

edited

Loading