fix(mdns): only advertise listening addresses matching the interface IP - #6500
Merged
mergify[bot] merged 6 commits intoSep 11, 2026
Merged
Conversation
MatthiasvB
force-pushed
the
fix/mdns-report-only-relevant-addresses
branch
from
June 23, 2026 14:35
a5db29d to
76d035c
Compare
When responding to mDNS queries, only advertise listening addresses whose IP matches the address family / interface the query arrived on, instead of advertising every listening address. Avoids announcing unreachable addresses.
MatthiasvB
force-pushed
the
fix/mdns-report-only-relevant-addresses
branch
from
July 4, 2026 11:40
76d035c to
ce98b8f
Compare
Contributor
|
This pull request has merge conflicts. Could you please resolve them @MatthiasvB? 🙏 |
The test swarms only listened on IPv4, but when IPv6 mDNS is enabled the interface task for the IPv6 interface only advertises addresses that match the interface IP. Listen on both address families so discovery works for both IPv4 and IPv6, now that responses only include addresses matching the queried interface.
jxs
force-pushed
the
fix/mdns-report-only-relevant-addresses
branch
from
September 10, 2026 14:13
b7ef561 to
8847f3d
Compare
elenaf9
approved these changes
Sep 11, 2026
elenaf9
left a comment
elenaf9
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay. Two nits, rest LGMT.
Co-authored-by: Elena Frank <elena.frank@proton.me>
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 1 minute 3 seconds in the queue, including 10 seconds running CI. Required conditions to merge
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When responding to mDNS queries, only advertise listening addresses whose IP matches the address family / interface the query arrived on, instead of advertising every listening address. Avoids announcing unreachable addresses.
Description
mDNS currently wildly reports all interface's addresses on all interfaces, which leads to mutiple issues:
Fixes #5995.
Fixes #5790.
There already is a PR, but it's been open for a long time and seems more complex: #6003
AI Assistance Disclosure
Tools used
Github Copilot (initially), rework using Claude Code (Opus 4.8)
Attestation (required):
Notes & open questions
The fix seems smart and in the right place, but I lack complete overview over the crate, so some expert review should verify this is a good spot for the fix
Change checklist