Skip to content

fix(ping/rust): Implemented 0.50 changes #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umgefahren wants to merge 3 commits into from
Closed

fix(ping/rust): Implemented 0.50 changes #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57b59b
Implemented 0.50 changes
umgefahren Nov 29, 2022
19a8de2
Update ping/rust/src/bin/testplan_0500.rs
mxinden Nov 30, 2022
745e41f
Made test plan run again
umgefahren Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ping/rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ libp2pv0490 = { package = "libp2p", version = "0.49.0", features = ["websocket",
[dependencies."libp2pv0500"]
package = "libp2p"
git = "https://github.com/libp2p/rust-libp2p"
rev = "368705a1465c4322948d14ee46d42475c472ca1e" # This should usually point to a commit on master.
tag = "v0.50.0"
Copy link
Member

@mxinden mxinden Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think moving to tag would work here, given that we use sed in our Dockerfile matching on the string rev.

I might have been not very clear. Sorry. Let's use the commit hash that v0.50.0 points at.

Copy link
Author

@umgefahren umgefahren Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see

Copy link
Contributor

@thomaseizinger thomaseizinger Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have released v0.50.0 we should actually add that as a release and have this point to the most recent hash on master here!

Copy link
Author

@umgefahren umgefahren Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of this PR?

Copy link
Contributor

@thomaseizinger thomaseizinger Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to be. I think we can merge this separately :)

Copy link
Contributor

@thomaseizinger thomaseizinger Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #87 and also fixed the deprecation warnings there.

features = ["websocket", "mplex", "yamux", "tcp", "ping", "noise", "dns", "async-std", "rsa", "macros"]
2 changes: 1 addition & 1 deletion ping/rust/src/bin/testplan_0500.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ async fn main() -> Result<()> {
let local_key = identity::Keypair::generate_ed25519();
let local_peer_id = PeerId::from(local_key.public());

let swarm = OrphanRuleWorkaround(Swarm::new(
let swarm = OrphanRuleWorkaround(Swarm::with_async_std_executor(
development_transport(local_key).await?,
Behaviour {
keep_alive: keep_alive::Behaviour,
Expand Down