Reserved char seq #165
Open
Reserved char seq #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d7a
reviewed
Nov 27, 2025
Member
6d7a
left a comment
6d7a
left a comment
There was a problem hiding this comment.
Looks good, just one question concerning the removed match arms.
| constraints, | ||
| distinguished_values: None, | ||
| }), | ||
| (None, BIT_STRING) => ASN1Type::BitString(BitString { |
Update test snapshots for `parses_modules` after pull request librasn#161 Parse ANY [DEFINED BY identifier].
Update test snapshots for `parses_modules` after pull request librasn#168 feat: Support T61String.
Update test snapshots for `parses_modules` after pull request librasn#169 feat: Generate bindings for UniversalString.
Update test snapshots for `parses_modules` after pull request librasn#170 Fix syntax errors in RFC 3281.
For example, split "SEQUENCE OF" into it's two reserved character sequences "SEQUENCE" and "OF". This is to better follow the reserved words, and also allows white space between words. Two more test modules are now parsing.
Fixes parsing of some more modules.
Rawk
force-pushed
the
reserved-char-seq
branch
from
f12c6e1 to
8278b85
Compare
Contributor
Author
|
I added the snapshot testing changes. This probably needs to be merged after #171 Update snapshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(parser): Split up combined reserved words
For example, split "SEQUENCE OF" into it's two reserved character sequences "SEQUENCE" and "OF". This is to better follow the reserved words, and also allows arbitrary white space between words.
fix(parser) CHOICE options no longer requires constraints
Parse tests outcome:
Success rate of 74%->75%.
Parsed 664->675 ASN1 modules without running into unrecoverable errors.
Failed to parse 228->217 modules with the following errors: ..